From owner-freebsd-bugs@freebsd.org Mon Jul 24 11:48:17 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41ECDC7BD54 for ; Mon, 24 Jul 2017 11:48:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 30DDA65553 for ; Mon, 24 Jul 2017 11:48:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6OBmHCn002032 for ; Mon, 24 Jul 2017 11:48:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 220965] Some dtrace_io probes lack struct bio reference Date: Mon, 24 Jul 2017 11:48:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fk@fabiankeil.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2017 11:48:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220965 Bug ID: 220965 Summary: Some dtrace_io probes lack struct bio reference Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: fk@fabiankeil.de According to dtrace_io(4) and "dtrace -lvn io:::", the dtrace_io probes use a struct bio * as arg[0] to represent the I/O request, however that is only true for the probes declared with a define with _BIO_ in its name. Quoting sys/kern/subr_devstat.c: 57 #define DTRACE_DEVSTAT_START() SDT_PROBE2(io, , , start, N= ULL, ds) 58 #define DTRACE_DEVSTAT_BIO_START() SDT_PROBE2(io, , , start, b= p, ds) 59 #define DTRACE_DEVSTAT_DONE() SDT_PROBE2(io, , , done, NU= LL, ds) 60 #define DTRACE_DEVSTAT_BIO_DONE() SDT_PROBE2(io, , , done, bp, ds) As a result, even simple scripts like the example in dtrace_io(4) result in errors like: dtrace: error on enabled probe ID 1 (ID 41752: io:kernel:none:start): inval= id address (0x20) in action #6 at DIF offset 16 One can workaround this by skipping probes without bio reference by adding: /args[0] !=3D NULL/ but it would be more convenient if probes with bio reference had a different name than those that don't. --=20 You are receiving this mail because: You are the assignee for the bug.=