Date: Mon, 28 Jul 2014 06:35:38 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192177] [patch] unbreak audio/umurmur after devel/protobuf-c upgrade to version 1.0.0 Message-ID: <bug-192177-13-1gpIzvOvEE@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192177-13@https.bugs.freebsd.org/bugzilla/> References: <bug-192177-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192177 --- Comment #6 from Don Lewis <truckman@FreeBSD.org> --- (In reply to John Marino from comment #3) > Don, FYI the way you are providing changes is not committer friendly. IIUC, > you provided 3 patches, but they are actually the contents of patches that > need to go in the files subdirectory. So you are asking somebody to > download each patch, rename it to > patch-<path-to-final-file-whatever-they-want>, move it to files, and > potentially revbump. > > What committers expect is a single diff that creates the patches in files > and makes any necessary changes to the other files (e.g. Makefile, > pkg-plist, etc). In other words, one diff that makes all the necessary > changes to update the port. > > So if you make maintenance harder (unnecessarily), the volunteer committer > may just move on looking for an easier PR to knock out. > > I'm just letting you know because I assume you didn't realize that your > approach wasn't friendly. This isn't a trivial patch and commit PR in any case, and I think my patches are just the starting point for further discussion. Another approach is to make the change to configure and then run protobuf-c in pre-build to update the other two source files. I did that manually to generate the patches for the other two files. Whatever approach is taken, it would be nice if someone could actually verify that the port still functions correction after it is updated. I've only verified that the changes that I made allow the port to build without error. I'm not a user of this port, so I can't verify functionality. I'm just trying to be a bit proactive in filing this PR because I know that the port is going to be broken soon. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192177-13-1gpIzvOvEE>