From owner-svn-src-head@FreeBSD.ORG Fri Apr 15 08:27:12 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95231106566B; Fri, 15 Apr 2011 08:27:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 9946E8FC0A; Fri, 15 Apr 2011 08:27:11 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p3F8R6Mw006835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 15 Apr 2011 11:27:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p3F8R6EX081608; Fri, 15 Apr 2011 11:27:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p3F8R6BR081607; Fri, 15 Apr 2011 11:27:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 15 Apr 2011 11:27:06 +0300 From: Kostik Belousov To: John Baldwin Message-ID: <20110415082706.GI48734@deviant.kiev.zoral.com.ua> References: <201104101707.p3AH736T054347@svn.freebsd.org> <201104141713.28311.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cW+P/jduATWpL925" Content-Disposition: inline In-Reply-To: <201104141713.28311.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS,FUZZY_CREDIT autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, trasz@freebsd.org Subject: Re: svn commit: r220526 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2011 08:27:12 -0000 --cW+P/jduATWpL925 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 14, 2011 at 05:13:28PM -0400, John Baldwin wrote: > On Sunday, April 10, 2011 1:07:03 pm Konstantin Belousov wrote: > > Author: kib > > Date: Sun Apr 10 17:07:02 2011 > > New Revision: 220526 > > URL: http://svn.freebsd.org/changeset/base/220526 > >=20 > > Log: > > Some callers of proc_reparent() already have the parent process locke= d. > > Detect the situation and avoid process lock recursion. > > =20 > > Reported by: Fabian Keil > >=20 > > Modified: > > head/sys/kern/kern_exit.c >=20 > Can we instead assert it is always held and fix callers that don't? Usin= g=20 > locked variables is messy and I'd rather avoid it when possible. We alre= ady=20 > require the caller to hold other locks for this operation. >=20 I agree that this is ugly, and proper fix probably would be something else. E.g. struct proc could grow another field that holds a pointer to the ucred it is accounted for, and locked with some global lock. --cW+P/jduATWpL925 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk2oAVoACgkQC3+MBN1Mb4ipJwCdGBm37JsjAiBc1EToMmI+b6Dp czgAoMIsuLe4E8WTDYf8pVNiMKUC87D5 =cQRQ -----END PGP SIGNATURE----- --cW+P/jduATWpL925--