From owner-p4-projects@FreeBSD.ORG  Sat Apr  4 20:44:18 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D701F1065672; Sat,  4 Apr 2009 20:44:17 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8FB3B106564A
	for <perforce@freebsd.org>; Sat,  4 Apr 2009 20:44:17 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D22E8FC15
	for <perforce@freebsd.org>; Sat,  4 Apr 2009 20:44:17 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n34KiHSj015986
	for <perforce@freebsd.org>; Sat, 4 Apr 2009 20:44:17 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n34KiHsk015984
	for perforce@freebsd.org; Sat, 4 Apr 2009 20:44:17 GMT
	(envelope-from csjp@freebsd.org)
Date: Sat, 4 Apr 2009 20:44:17 GMT
Message-Id: <200904042044.n34KiHsk015984@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 160213 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Apr 2009 20:44:19 -0000

http://perforce.freebsd.org/chv.cgi?CH=160213

Change 160213 by csjp@hvm02 on 2009/04/04 20:43:34

	- Fix code example in man page
	- make it clear we are after the audit id

Affected files ...

.. //depot/projects/trustedbsd/openbsm/NEWS#38 edit
.. //depot/projects/trustedbsd/openbsm/libbsm/audit_submit.3#16 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/NEWS#38 (text+ko) ====

@@ -13,6 +13,8 @@
   definitions of constants in audit_fcntl.h.
 - A bug, introduced in OpenBSM 1.1 alpha 4, in which AUT_RETURN32 tokens
   generated by audit_submit(3) were improperly encoded has been fixed.
+- Fix example in audit_submit(3) man page.  Also, make it clear that we want
+  the audit ID as the argument.
 
 OpenBSM 1.1 beta 1
 
@@ -445,4 +447,4 @@
   to support reloading of kernel event table.
 - Allow comments in /etc/security configuration files.
 
-$P4: //depot/projects/trustedbsd/openbsm/NEWS#37 $
+$P4: //depot/projects/trustedbsd/openbsm/NEWS#38 $

==== //depot/projects/trustedbsd/openbsm/libbsm/audit_submit.3#16 (text+ko) ====

@@ -27,7 +27,7 @@
 .\" IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 .\" POSSIBILITY OF SUCH DAMAGE.
 .\"
-.\" $P4: //depot/projects/trustedbsd/openbsm/libbsm/audit_submit.3#15 $
+.\" $P4: //depot/projects/trustedbsd/openbsm/libbsm/audit_submit.3#16 $
 .\"
 .Dd January 18, 2008
 .Dt audit_submit 3
@@ -101,9 +101,12 @@
 int
 audit_bad_su(char *from_login, char *to_login)
 {
+	struct auditinfo_addr aia;
 	int error;
 
-	error = audit_submit(AUE_su, getuid(), 1, EPERM,
+	if (getaudit_addr(&aia, sizeof(aia) < 0)
+		err(1, "getaudit_addr");
+	error = audit_submit(AUE_su, aia.ai_auid, EPERM, 1,
 	    "bad su from %s to %s", from_login, to_login);
 	return (error);
 }