From owner-cvs-ports@FreeBSD.ORG Wed May 23 14:39:20 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 399A11065670; Wed, 23 May 2012 14:39:20 +0000 (UTC) (envelope-from decke@FreeBSD.org) Received: from groupware.itac.at (groupware.itac.at [91.205.172.99]) by mx1.freebsd.org (Postfix) with ESMTP id ABF998FC0C; Wed, 23 May 2012 14:39:19 +0000 (UTC) Received: from home.bluelife.at (93.104.210.95) by groupware.itac.at (Axigen) with (AES256-SHA encrypted) ESMTPSA id 00534F; Wed, 23 May 2012 16:39:47 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 23 May 2012 16:39:18 +0200 From: Bernhard Froehlich To: Pav Lucistnik In-Reply-To: <1337781346.2024.8.camel@pav.hide.vol.cz> References: <201205231334.q4NDYCMQ078804@repoman.freebsd.org> <1337780396.2024.2.camel@pav.hide.vol.cz> <9b15e44319f017bff90bc3caa1de79d9@bluelife.at> <1337781238.2024.7.camel@pav.hide.vol.cz> <1337781346.2024.8.camel@pav.hide.vol.cz> Message-ID: X-Sender: decke@FreeBSD.org User-Agent: Roundcube Webmail/0.7.2 X-AxigenSpam-Level: 1 X-CTCH-RefID: str=0001.0A0B020B.4FBCF696.0171,ss=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, Bernhard Froehlich , cvs-all@freebsd.org, Martin Wilke Subject: Re: cvs commit: ports/databases/pg_filedump Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2012 14:39:20 -0000 On 23.05.2012 15:55, Pav Lucistnik wrote: > Pav Lucistnik píše v st 23. 05. 2012 v 15:53 +0200: >> Bernhard Froehlich píše v st 23. 05. 2012 v 15:47 +0200: >> > On 23.05.2012 15:39, Pav Lucistnik wrote: >> > > Martin Wilke píše v st 23. 05. 2012 v 13:34 +0000: >> > >> miwi 2012-05-23 13:34:12 UTC >> > >> >> > >> FreeBSD ports repository >> > >> >> > >> Modified files: >> > >> databases/pg_filedump Makefile >> > >> Log: >> > >> - Switch to FETCH_DEPENDS to fix fetch during build >> > > >> > > How is this supposed to work? The log message makes no sense. >> > >> > The problem that this fixes is when you are building in jails >> > and restrict internet access to the "fetch" target like >> > pointyhat-west, redports.org and poudriere already do. >> >> Well, the restriction was put in place for a reason 1*), and now >> you're >> working around that very reason. So just remove the restriction from >> pointyhat and problem solved. > > On a second read, now I see what you're achieving. But still, the > chosen > solution seems suboptimal. On the list of broken ports there are a handful of ports (including this one) that depend on another ports code (aka working directory). Right now those ports are written using a dirty hack like that: from databases/mysql-q4m: BUILD_DEPENDS= ${NONEXISTENT}:${PORTSDIR}/databases/mysql${MYSQL_VER}-server:build CONFIGURE_ARGS= --with-mysql="$$(cd ${PORTSDIR}/databases/mysql${MYSQL_VER}-server; ${MAKE} -V WRKSRC)" We decided to choose the s/BUILD_DEPENDS/FETCH_DEPENDS/ solution because it doesn't actually make the hack much worse than it already is. The downside is that it builds during fetch which isn't nice but better than fetch during build which is a security improvement. If someone comes up with a better solution without completely rewriting all those ports I would be glad to help doing it. Right now it looks like there are around 5-10 ports of that kind. -- Bernhard Froehlich http://www.bluelife.at/