From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Sep 30 18:40:04 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C32CF1065676 for ; Wed, 30 Sep 2009 18:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A1B9C8FC15 for ; Wed, 30 Sep 2009 18:40:04 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8UIe4Nq081199 for ; Wed, 30 Sep 2009 18:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8UIe46g081198; Wed, 30 Sep 2009 18:40:04 GMT (envelope-from gnats) Resent-Date: Wed, 30 Sep 2009 18:40:04 GMT Resent-Message-Id: <200909301840.n8UIe46g081198@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Vivek Khera Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF1B4106566B for ; Wed, 30 Sep 2009 18:32:24 +0000 (UTC) (envelope-from vivek@kciLink.com) Received: from yertle.kcilink.com (thingy.kcilink.com [74.92.149.59]) by mx1.freebsd.org (Postfix) with ESMTP id C91B78FC08 for ; Wed, 30 Sep 2009 18:32:24 +0000 (UTC) Received: from vk-dev.int.kcilink.com (vk-dev.int.kcilink.com [192.168.7.96]) by yertle.kcilink.com (Postfix) with ESMTP id C5DCB8A250 for ; Wed, 30 Sep 2009 14:32:23 -0400 (EDT) Received: by vk-dev.int.kcilink.com (Postfix, from userid 1002) id B71AB3F43F; Wed, 30 Sep 2009 14:32:23 -0400 (EDT) Message-Id: <20090930183223.B71AB3F43F@vk-dev.int.kcilink.com> Date: Wed, 30 Sep 2009 14:32:23 -0400 (EDT) From: Vivek Khera To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/139259: fix crash in p5-CGI-SpeedyCGI port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Vivek Khera List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2009 18:40:04 -0000 >Number: 139259 >Category: ports >Synopsis: fix crash in p5-CGI-SpeedyCGI port >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Sep 30 18:40:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Vivek Khera >Release: FreeBSD 7.2-RELEASE i386 >Organization: >Environment: System: FreeBSD vk-dev.int.kcilink.com 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Mon May 11 14:14:08 EDT 2009 vivek@vk-dev.int.kcilink.com:/n/yertle1/sources/usr7/obj.i386/n/yertle1/sources/usr7/src/sys/KCI32 i386 >Description: Port www/p5-CGI-SpeedyCGI with perl 5.10, speedy tends to segfault when the program calls exit() after the first time it is run. See also bug report from Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537996 >How-To-Repeat: see above bug report from debian. it may or may not happen on any given machine. on my machines i have a big program from our application that does it. >Fix: this is the patch copied from debian into the port. diff -Nru p5-CGI-SpeedyCGI.old/files/patch-src_speedy_perl.c p5-CGI-SpeedyCGI/files/patch-src_speedy_perl.c --- p5-CGI-SpeedyCGI.old/files/patch-src_speedy_perl.c 1969-12-31 19:00:00.000000000 -0500 +++ p5-CGI-SpeedyCGI/files/patch-src_speedy_perl.c 2009-09-30 14:23:17.000000000 -0400 @@ -0,0 +1,15 @@ +Author: Niko Tyni +Description: Closes: #537996 +The SvIV call crashes in on Perl 5.10.0 when warnings are +enabled and the value is undef. +--- src/speedy_perl.c ++++ src/speedy_perl.c +@@ -818,7 +818,7 @@ + my_call_sv(get_perlvar(&PERLVAR_RESET_GLOBALS)); + + /* Copy option values in from the perl vars */ +- if (SvIV(PERLVAL_OPTS_CHANGED)) { ++ if (SvTRUE(PERLVAL_OPTS_CHANGED)) { + int i; + for (i = 0; i < SPEEDY_NUMOPTS; ++i) { + OptRec *o = speedy_optdefs + i; >Release-Note: >Audit-Trail: >Unformatted: