From owner-svn-src-all@freebsd.org Wed Oct 28 11:54:08 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0883D443C15; Wed, 28 Oct 2020 11:54:08 +0000 (UTC) (envelope-from arichardson@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLn6R10H5z417r; Wed, 28 Oct 2020 11:54:06 +0000 (UTC) (envelope-from arichardson@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 603311BF0F; Wed, 28 Oct 2020 11:54:05 +0000 (UTC) (envelope-from arichardson@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 09SBs5Sh097283; Wed, 28 Oct 2020 11:54:05 GMT (envelope-from arichardson@FreeBSD.org) Received: (from arichardson@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 09SBs5WP097282; Wed, 28 Oct 2020 11:54:05 GMT (envelope-from arichardson@FreeBSD.org) Message-Id: <202010281154.09SBs5WP097282@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: arichardson set sender to arichardson@FreeBSD.org using -f From: Alex Richardson Date: Wed, 28 Oct 2020 11:54:05 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r367101 - head/lib/googletest/tests X-SVN-Group: head X-SVN-Commit-Author: arichardson X-SVN-Commit-Paths: head/lib/googletest/tests X-SVN-Commit-Revision: 367101 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 11:54:12 -0000 Author: arichardson Date: Wed Oct 28 11:54:04 2020 New Revision: 367101 URL: https://svnweb.freebsd.org/changeset/base/367101 Log: Significantly reduce compile time for googletest internal tests Clang's optimizer spends a really long time on these tests at -O2, so we now use -O0 instead. This reduces the -j32 time for lib/googletest/test from 131s to 29s. Using -O0 also reduces the disk usage from 144MB (at -O2) / 92MB (at -O1) to 82MB. Reviewed By: ngie, dim Differential Revision: https://reviews.freebsd.org/D26751 Modified: head/lib/googletest/tests/Makefile.inc Modified: head/lib/googletest/tests/Makefile.inc ============================================================================== --- head/lib/googletest/tests/Makefile.inc Wed Oct 28 11:54:00 2020 (r367100) +++ head/lib/googletest/tests/Makefile.inc Wed Oct 28 11:54:04 2020 (r367101) @@ -4,3 +4,15 @@ # Keep the existing tests directory structure (with subdirs per component) # rather than installing all of them to /usr/tests/lib/googletest TESTSDIR= ${TESTSBASE}/lib/googletest/${.CURDIR:T} + +# Clang's optimizer spends a really long time on these tests at -O2. Changing +# -O2 to -O1 reduces the -j32 time for lib/googletest/test from 131s to 71s. +# Using -O0 further reduces the time to 29s, and also reduces the disk usage +# from 144MB (at -O2) / 92MB (at -O1) to 82MB, so we use -O0. +# Note: Building without debug info saves about 10-15% of the build time, so we +# only enable debug info if DEBUG_FLAGS is not empty (71s -> 64s at -O1 and -j32). +CFLAGS.clang+= -O0 +.if empty(DEBUG_FLAGS) +MK_DEBUG_FILES:=no +CFLAGS.clang+= -g0 +.endif