From owner-svn-src-all@FreeBSD.ORG Sat Dec 18 10:35:50 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C4DB106564A; Sat, 18 Dec 2010 10:35:50 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from mail.vnode.se (mail.vnode.se [62.119.52.80]) by mx1.freebsd.org (Postfix) with ESMTP id C49058FC12; Sat, 18 Dec 2010 10:35:49 +0000 (UTC) Received: from mail.vnode.se (localhost [127.0.0.1]) by mail.vnode.se (Postfix) with ESMTP id 71F36E3F07B; Sat, 18 Dec 2010 11:35:48 +0100 (CET) X-Virus-Scanned: amavisd-new at vnode.se Received: from mail.vnode.se ([127.0.0.1]) by mail.vnode.se (mail.vnode.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iMQQKoabxXJR; Sat, 18 Dec 2010 11:35:45 +0100 (CET) Received: from pluto.vnode.local (unknown [83.223.1.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.vnode.se (Postfix) with ESMTPSA id 00053E3F079; Sat, 18 Dec 2010 11:35:44 +0100 (CET) Date: Sat, 18 Dec 2010 11:35:42 +0100 From: Joel Dahl To: Alan Cox Message-ID: <20101218103542.GB59878@pluto.vnode.local> References: <201012092016.oB9KG05P049565@svn.freebsd.org> <20101218070800.GA59878@pluto.vnode.local> <4D0C7C0F.4000703@rice.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D0C7C0F.4000703@rice.edu> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Alan Cox , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216333 - head/sys/i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Dec 2010 10:35:50 -0000 On 18-12-2010 3:17, Alan Cox wrote: > Joel Dahl wrote: > > On 09-12-2010 20:16, Alan Cox wrote: > > > >> Author: alc > >> Date: Thu Dec 9 20:16:00 2010 > >> New Revision: 216333 > >> URL: http://svn.freebsd.org/changeset/base/216333 > >> > >> Log: > >> When r207410 eliminated the acquisition and release of the page queues > >> lock from pmap_extract_and_hold(), it didn't take into account that > >> pmap_pte_quick() sometimes requires the page queues lock to be held. > >> This change reimplements pmap_extract_and_hold() such that it no > >> longer uses pmap_pte_quick(), and thus never requires the page queues > >> lock. > >> > >> For consistency, adopt the same idiom as used by the new > >> implementation of pmap_extract_and_hold() in pmap_extract() and > >> pmap_mincore(). It also happens to make these functions shorter. > >> > > > > Hi Alan, > > > > This commit makes my laptop hang everytime I quit X. I just get a black > > screen and the machine won't respond to any keys. Everything works if I > > go back to r216330. > > > > > > Can you please try the following change? I'm afraid the patch didn't make any difference. It still hangs. -- Joel