From owner-cvs-all@FreeBSD.ORG Thu Sep 17 19:04:47 2009 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7023710656A3 for ; Thu, 17 Sep 2009 19:04:47 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from capeta.freebsdbrasil.com.br (capeta.freebsdbrasil.com.br [201.48.151.3]) by mx1.freebsd.org (Postfix) with SMTP id 62FEA8FC33 for ; Thu, 17 Sep 2009 19:04:45 +0000 (UTC) Received: (qmail 40249 invoked from network); 17 Sep 2009 16:04:43 -0300 Received: by simscan 1.4.0 ppid: 40221, pid: 40238, t: 0.4978s scanners:none Received: from unknown (HELO botelhor.bplab.local) (garga@189.19.84.134) by capeta.freebsdbrasil.com.br with ESMTPA; 17 Sep 2009 16:04:42 -0300 Received: (qmail 47386 invoked by uid 1001); 17 Sep 2009 16:05:41 -0300 Date: Thu, 17 Sep 2009 16:05:41 -0300 From: Renato Botelho To: Doug Barton Message-ID: <20090917190540.GA20217@bluepex.com> References: <200909131035.n8DAZND8097060@repoman.freebsd.org> <4AB28654.4090706@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; x-action=pgp-signed Content-Disposition: inline In-Reply-To: <4AB28654.4090706@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Henrik Brix Andersen , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/irc/bitlbee/files bitlbee.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2009 19:04:47 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, Sep 17, 2009 at 11:56:20AM -0700, Doug Barton wrote: > Henrik Brix Andersen wrote: > > brix 2009-09-13 10:35:23 UTC > > > > FreeBSD ports repository > > > > Modified files: > > irc/bitlbee/files bitlbee.in > > Log: > > - Use -u ${user} option to bitlbee instead of su in rc.d script > > > > PR: ports/138268 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=138268 > > Submitted by: garga > > > > Revision Changes Path > > 1.4 +2 -2 ports/irc/bitlbee/files/bitlbee.in > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/bitlbee/files/bitlbee.in.diff?&r1=1.3&r2=1.4&f=h > > With this change the script can be further simplified as attached. > LOGIN is needed instead of DAEMON since it's running as a specific > user. We also generally prefer that ports stuff uses LOGIN unless > something earlier is needed. > > > hth, > > Doug > > -- > > This .signature sanitized for your protection > > --- /usr/ports/irc/bitlbee/files/bitlbee.in 2009-09-14 13:04:11.000000000 -0700 > +++ bitlbee.in 2009-09-17 11:53:39.000000000 -0700 > @@ -3,7 +3,7 @@ > # $FreeBSD: ports/irc/bitlbee/files/bitlbee.in,v 1.4 2009/09/13 10:35:23 brix Exp $ > # > # PROVIDE: bitlbee > -# REQUIRE: DAEMON > +# REQUIRE: LOGIN > # KEYWORD: shutdown > > # Add the following lines to /etc/rc.conf to enable bitlbee: > @@ -23,12 +23,6 @@ > > required_files="${bitlbee_config}" > command="%%PREFIX%%/sbin/bitlbee" > -start_cmd="bitlbee_start" > - > -bitlbee_start() > -{ > - echo "Starting ${name}." > - ${command} -D -u ${bitlbee_user} -c ${bitlbee_config} ${bitlbee_flags} > -} > +command_args="-D -u ${bitlbee_user} -c ${bitlbee_config}" > > run_rc_command "$1" Indeed, seems really better - -- Renato Botelho GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc Song Title of the Week: "They're putting dimes in the hole in my head to see the change in me." -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAkqyiIQACgkQ6CRbiSJE7alfQgCfSskqtlU26TnLebTOj/G4KSY6 2KoAnj0fghYbC9Y+3UtawQuRGnebY4UG =dy/R -----END PGP SIGNATURE-----