From owner-freebsd-net@freebsd.org Tue Mar 23 18:35:15 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A63A5B7DD3 for ; Tue, 23 Mar 2021 18:35:15 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4g5t70d7z3mBh; Tue, 23 Mar 2021 18:35:14 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2a02:8109:1140:c3d:3063:f2ec:8e4c:4b] (unknown [IPv6:2a02:8109:1140:c3d:3063:f2ec:8e4c:4b]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 69B797229E452; Tue, 23 Mar 2021 19:35:10 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: tcp-testsuite into src? From: tuexen@freebsd.org In-Reply-To: Date: Tue, 23 Mar 2021 19:35:09 +0100 Cc: Alan Somers , Kevin Bowling , FreeBSD Net , rscheff@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3FCBFDBF-A0F9-450C-98D3-5C7D853AF214@freebsd.org> References: To: George Neville-Neil X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4F4g5t70d7z3mBh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 18:35:15 -0000 > On 23. Mar 2021, at 12:26, George Neville-Neil = wrote: >=20 >=20 >=20 > On 22 Mar 2021, at 22:45, Alan Somers wrote: >=20 >> On Mon, Mar 22, 2021 at 7:31 PM Kevin Bowling = >> wrote: >>=20 >>> Hi, >>>=20 >>> I was talking with gnn and kevans on IRC about the tcp testsuite >>> (https://github.com/freebsd-net/tcp-testsuite). >>>=20 >>> Currently we maintain this in ports, although the way the port is = set >>> up doesn't make a lot of sense because the tests are stack specific >>> and we don't account for different FreeBSD versions let alone vendor >>> trees. It seems reasonable to me to pull the tests themselves (i.e. >>> https://github.com/freebsd-net/tcp-testsuite) into src where they = can >>> follow along with the tree they are running on, and provide vendors = a >>> natural point of extension. >>>=20 >>> /usr/tests has some existing examples of relying on out of tree >>> binaries to run so I am not convinced we need to import packetdrill >>> itself but I don't have a strong preference. tuexen, do you have = any >>> preference? >>>=20 >>> Regards, >>> Kevin >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" >>>=20 >>=20 >> Yeah, it's not a problem to use binaries from ports in /usr/tests. = As long >> as the tests can compile they can live in the base system. Is there = a >> strong incentive to import them? Do they need to be adjusted for = each >> release? >=20 > I found out this morning that moving the tests into base is indeed the = plan: >=20 > https://wiki.freebsd.org/TransportProtocols/11March2021 Well, it was discussed, and no-one objected up to now. I'm not familiar = with the test infrastructure used by FreeBSD. I'm running the TCP tests using shell scripts which are part of the repository. To get it into the source tree, it would be great to have someone to = talk to, who has some experience with test infrastructure used by FreeBSD. Anyone volunteering? >=20 > I'm happy to see this happen. >=20 > The next step will be documentation of how to add new/good tests to = the suite. Up to now, the test groups are written around specifications. So can you = list which specifications you would like to have covered? Best regards Michael >=20 > Best, > George