From owner-freebsd-bugs@freebsd.org  Mon Nov 28 03:14:18 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B04A6C58B33
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Mon, 28 Nov 2016 03:14:18 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9560DCBE
 for <freebsd-bugs@FreeBSD.org>; Mon, 28 Nov 2016 03:14:18 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uAS3EIYQ083845
 for <freebsd-bugs@FreeBSD.org>; Mon, 28 Nov 2016 03:14:18 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 214874] ctld daemon wrong lun_size value on i386
Date: Mon, 28 Nov 2016 03:14:18 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: pprocacci@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-214874-8-9Kth7t4PmC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-214874-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-214874-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Nov 2016 03:14:18 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214874

--- Comment #2 from pprocacci@gmail.com ---
sizeof(size_t) =3D=3D 4
sizeof(uint64_t) =3D=3D 8

The cast from uint64_t to size_t is killing the value.

This small patch fixes the problem, though I'm not sure what ill effects th=
is
may have.


diff -ur ctld.orig ctld
diff -ur ctld.orig/ctld.c ctld/ctld.c
--- ctld.orig/ctld.c    2016-11-27 22:12:27.525990000 -0500
+++ ctld/ctld.c 2016-11-27 22:09:25.798040000 -0500
@@ -1496,7 +1496,7 @@
 }

 void
-lun_set_size(struct lun *lun, size_t value)
+lun_set_size(struct lun *lun, uint64_t value)
 {
        lun->l_size =3D value;
 }
Only in ctld.orig: ctld.c.orig
diff -ur ctld.orig/ctld.h ctld/ctld.h
--- ctld.orig/ctld.h    2016-11-27 22:12:16.851553000 -0500
+++ ctld/ctld.h 2016-11-27 22:10:31.732258000 -0500
@@ -388,7 +388,7 @@
 void                   lun_set_path(struct lun *lun, const char *value);
 void                   lun_set_scsiname(struct lun *lun, const char *value=
);
 void                   lun_set_serial(struct lun *lun, const char *value);
-void                   lun_set_size(struct lun *lun, size_t value);
+void                   lun_set_size(struct lun *lun, uint64_t value);
 void                   lun_set_ctl_lun(struct lun *lun, uint32_t value);

 struct option          *option_new(struct options *os,

--=20
You are receiving this mail because:
You are the assignee for the bug.=