From nobody Tue Sep 23 12:03:28 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cWJXd17svz68Y6v; Tue, 23 Sep 2025 12:03:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cWJXc6Ypcz3DVT; Tue, 23 Sep 2025 12:03:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758629008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qnTgPN7iGgfec+9d036ZN6iK12g0E0MacDBfgDyY6RY=; b=KSq5nB9DJkmnfMr1nGdeDoBI50f/S0cKgUKVFtbO3Ba/jLWd99W9+HQrOH4wMrR/OQGdmp +Ii0mRxg92JuSKp2LxubkulJc4lBLgQ0WrRNZwGncUXEvbPQr0AkZdiVYV2g/FntqIAT1S s9CnD2dVSlKp/EGimN2+Ih98ByQpCNb3uG45KS64NV6MlN/OFbUHykBftAQnxrz3nE8FZ/ tNLrVhDWLxPwHVB5B9O5wONbz8sqV1u865KubRE7enqbvTAFz0+gYVSs3mYJ131k/8S0+W vvvFhsLx6uvXQGqUyGq/Mq7E7yOUPleWVYwD0qIR3gK7Az+1VNaCbojDZJgOKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758629008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qnTgPN7iGgfec+9d036ZN6iK12g0E0MacDBfgDyY6RY=; b=HgBcIT9nncFPbkjbXQ+fGf+LBUzMNdLmihH1lTz0P80+SlEAvdW1jMoJ9ICaFIyzCy3KR7 abFgpKlIzYmgIK3PxDfP+pbQU7bvur5OXL7auIkO/GKOC2Qvu5T+cQZ1GfYWMZ5w/ggAJG HDk1qNLfCEAfc/mCzw/hdIw6Eqf5nLsVEeFXBZG5Ix6K0wPPpxuDikfv1qRWIY/w2gmqaZ wTQgvmEo/hm2zysTI5JJaVG8XB+JnV6RJqOE5LLQXGfXKan4aJmWg8PxjtNGD6WekMLtbp eNcbAJALJyXBmz4/03vuKXBXvsFAU0s7Fm2odLoC8cRkk4Z+4bm14EgNDsxnlA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758629008; a=rsa-sha256; cv=none; b=ACWKWWQJYT5ElUhJvMcyYmFxK53T40Qs8nhR1bFT68Dhn4jMaahgmGYyx8pYlHVZbovKAb LoRh6w4B/a6f4H2zHmRU2W7o/tJv88QJSfK3z12nO2yPAj0LyIdQ9mT00EsEOrO3N9Xpjj 07Kf30TBEKgo2TwWwZ3E4YZtp2/vq4XUJe33PbC8nicapsFn4zRaptX6d1QQVy6UfI1MtG 9/1dO748cnMVUWWs1fAe69JKerDdVEDui0OPX6hJiN9950i/Xqqh1mVDdg2cYlDzD4PKF0 KSLGMkR2aFUgxrvcoGusjKDB9KPl3xpg6rpsaQAIIOxg5x5n2P1HR9kDd1GeGA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cWJXc5fWjzllT; Tue, 23 Sep 2025 12:03:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58NC3SKd008296; Tue, 23 Sep 2025 12:03:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58NC3SMg008293; Tue, 23 Sep 2025 12:03:28 GMT (envelope-from git) Date: Tue, 23 Sep 2025 12:03:28 GMT Message-Id: <202509231203.58NC3SMg008293@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 5e4493dca3eb - stable/15 - nfsd: nfsd_excred(): Remove an obsolete comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 5e4493dca3ebee9cf627acd1ea5682cc704526ec Auto-Submitted: auto-generated The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=5e4493dca3ebee9cf627acd1ea5682cc704526ec commit 5e4493dca3ebee9cf627acd1ea5682cc704526ec Author: Olivier Certner AuthorDate: 2025-08-27 13:40:42 +0000 Commit: Olivier Certner CommitDate: 2025-09-23 12:02:41 +0000 nfsd: nfsd_excred(): Remove an obsolete comment This comment has been obsoleted by commit be1f7435ef21 ("kern: start tracking cr_gid outside of cr_groups[]."). No functional change. MFC after: 5 days MFC to: stable/15 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52264 (cherry picked from commit 5fa6ca8b8affc8d948687c4ede7aeed297ae2dc0) --- sys/fs/nfsserver/nfs_nfsdport.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdport.c b/sys/fs/nfsserver/nfs_nfsdport.c index 7040c4afb797..5ba86314ead1 100644 --- a/sys/fs/nfsserver/nfs_nfsdport.c +++ b/sys/fs/nfsserver/nfs_nfsdport.c @@ -3478,11 +3478,6 @@ nfsd_excred(struct nfsrv_descript *nd, struct nfsexstuff *exp, (nd->nd_flag & ND_AUTHNONE) != 0) { nd->nd_cred->cr_uid = credanon->cr_uid; nd->nd_cred->cr_gid = credanon->cr_gid; - /* - * 'credanon' is already a 'struct ucred' that was built - * internally with calls to crsetgroups_and_egid(), so - * we don't need a fallback here. - */ crsetgroups(nd->nd_cred, credanon->cr_ngroups, credanon->cr_groups); } else if ((nd->nd_flag & ND_GSS) == 0) {