From owner-cvs-src-old@FreeBSD.ORG  Wed Jun 24 21:10:15 2009
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 789101065689
	for <cvs-src-old@freebsd.org>; Wed, 24 Jun 2009 21:10:15 +0000 (UTC)
	(envelope-from gallatin@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 657518FC14
	for <cvs-src-old@freebsd.org>; Wed, 24 Jun 2009 21:10:15 +0000 (UTC)
	(envelope-from gallatin@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5OLAFNc068271
	for <cvs-src-old@freebsd.org>; Wed, 24 Jun 2009 21:10:15 GMT
	(envelope-from gallatin@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5OLAFkw068270
	for cvs-src-old@freebsd.org; Wed, 24 Jun 2009 21:10:15 GMT
	(envelope-from gallatin@repoman.freebsd.org)
Message-Id: <200906242110.n5OLAFkw068270@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	gallatin@repoman.freebsd.org using -f
From: Andrew Gallatin <gallatin@FreeBSD.org>
Date: Wed, 24 Jun 2009 21:09:56 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/dev/mxge if_mxge.c if_mxge_var.h
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2009 21:10:15 -0000

gallatin    2009-06-24 21:09:56 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/mxge         if_mxge.c if_mxge_var.h 
  Log:
  SVN rev 194909 on 2009-06-24 21:09:56Z by gallatin
  
  Add a dying flag to prevent races at detach.
  
  I tried re-ordering ether_ifdetach(), but this created a new race
  where sometimes, when under heavy receive load (>1Mpps) and running
  tcpdump, the machine would panic.  At panic, the ithread was still in
  the original (not dead) if_input() path, and was accessing stale BPF
  data structs.  By using a dying flag, I can close the interface prior
  to if_detach() to be certain the interface cannot send packets up in
  the middle of ether_ifdetach.
  
  Revision  Changes    Path
  1.62      +6 -0      src/sys/dev/mxge/if_mxge.c
  1.30      +1 -0      src/sys/dev/mxge/if_mxge_var.h