From owner-freebsd-hackers@FreeBSD.ORG Wed Jul 16 17:08:00 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5D5297F7 for ; Wed, 16 Jul 2014 17:08:00 +0000 (UTC) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) by mx1.freebsd.org (Postfix) with ESMTP id 3947D2CC4 for ; Wed, 16 Jul 2014 17:08:00 +0000 (UTC) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 00CDD5A9F0C; Wed, 16 Jul 2014 17:07:58 +0000 (UTC) Date: Wed, 16 Jul 2014 17:07:58 +0000 From: Brooks Davis To: Sean Fagan Subject: Re: Expanding on NO_ROOT: Categorizing installed files Message-ID: <20140716170758.GE60425@spindle.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CdrF4e02JqNVZeln" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 17:08:00 -0000 --CdrF4e02JqNVZeln Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 15, 2014 at 02:10:24PM -0700, Sean Fagan wrote: > Based on feedback primarily from Brooke Davis, an update. The diffs are = at http://earth.kithrup.com/~sef/auto-diffs.txt -- due to the size, I could= not send them to the mailing list. >=20 > This primarily eliminates the environment passing; the cost of that is a = lot more invasiveness. (About 100k larger diffs, thus being unable to atta= ch them.) The vast majorify of the diff is make debugging garbage that looks like it was committed by accident. I won't provided any detailed review of the current patch except to say that there are a lot of apparently redundent instances of setting META_CATEGORY in Makefiles and still quite a lot of instances of .EXPORTVAR: META_CATEGORY. > I have not changed it from having a new "category=3D" to using "tag=3D"; = I looked at that, and don't think it's the best way to go, but am still loo= king. Given that the current use of tags=3D is basically unconsumed, I still don't understand why. > I also want to go over it and ensure that NO_ROOT is a strict superset of= LOG_META_INFO -- that is, -DNO_ROOT should set -DLOG_META_INFO, and thus m= ost places where I check for either, I should only check for LOG_META_INFO. That seems like a good direction. -- Brooks --CdrF4e02JqNVZeln Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlPGsW4ACgkQXY6L6fI4GtTqXgCeMaBlQCEWKN14WytR/S4NiqhO kRsAniK9Qj9UQCzphBV/qdggIk7i3i/k =+NRR -----END PGP SIGNATURE----- --CdrF4e02JqNVZeln--