Date: Mon, 21 Mar 2005 18:19:19 GMT From: Oberon <ser_canof@tin.it> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/79098: [patch] multimedia/mplayer-skins won't create 'default' symlink if the default skin is installed Message-ID: <200503211819.j2LIJJ6o060667@www.freebsd.org> Resent-Message-ID: <200503211820.j2LIK3DI014121@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 79098
>Category: ports
>Synopsis: [patch] multimedia/mplayer-skins won't create 'default' symlink if the default skin is installed
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 21 18:20:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Oberon
>Release: FreeBSD 5.4-PRERELEASE
>Organization:
>Environment:
FreeBSD alfa.THOR 5.4-PRERELEASE FreeBSD 5.4-PRERELEASE #0: Sun Mar 20 16:20:39 CET 2005 oberon@alfa.THOR:/usr/obj/usr/src/sys/ROCCIA i386
>Description:
If WITH_SKIN_DEFAULT is setted to "yes", multimedia/mplayer-skins won't make the symlink from /usr/local/share/mplayer/Skin/Blue to /usr/local/share/mplayer/Skin/default; if it isn't setted to "yes", multimedia/mplayer-skins will make an analogous symlink
>How-To-Repeat:
cd ${PORTSDIR}/multimedia/mplayer-skins
make install
ls -l /usr/local/share/mplayer/Skin/ | grep default
make deinstall
first WITH_SKIN_DEFAULT, then without.
>Fix:
patch for Makefile:
> diff -u Makefile.orig Makefile
--- Makefile.orig Mon Mar 21 18:01:44 2005
+++ Makefile Mon Mar 21 17:38:50 2005
@@ -217,9 +217,9 @@
do-install:
# create target directories
@${MKDIR} ${PREFIX}/${myDATADIR}
-#.if defined(WITH_SKIN_DEFAULT)
-# @${LN} -sf "${PREFIX}/${myDATADIR}/Blue" "${PREFIX}/${myDATADIR}/default"
-#.endif
+.if defined(WITH_SKIN_DEFAULT)
+ @${LN} -sf "${PREFIX}/${myDATADIR}/Blue" "${PREFIX}/${myDATADIR}/default"
+.endif
# both anotate and create target directories
@for dir in `cd ${WRKDIR} && ${FIND} . -type d ! -name ".*" | ${SORT} -r` ; do \
${MKDIR} "${PREFIX}/${myDATADIR}/$${dir#./}" ; \
patch for pkg-plist:
> diff -u pkg-plist.org pkg-plist
--- pkg-plist.orig Mon Mar 21 19:13:40 2005
+++ pkg-plist Mon Mar 21 19:11:57 2005
@@ -1626,7 +1626,7 @@
%%XMMPLAYER%%share/mplayer/Skin/xmmplayer/symbols.fnt
%%XMMPLAYER%%share/mplayer/Skin/xmmplayer/symbols.png
%%XMMPLAYER%%share/mplayer/Skin/xmmplayer/volume.png
-%%WITHOUT_SKIN_DEFAULT%%share/mplayer/Skin/default
+share/mplayer/Skin/default
share/mplayer/Skin/%%PKGNAME%%
%%XMMPLAYER%%@dirrm share/mplayer/Skin/xmmplayer
%%XINE_LCD%%@dirrm share/mplayer/Skin/xine-lcd
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503211819.j2LIJJ6o060667>