From owner-freebsd-bugs@FreeBSD.ORG  Tue Jul 11 01:30:13 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 54C4F16A4DA
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 11 Jul 2006 01:30:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BC2ED43D49
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 11 Jul 2006 01:30:12 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k6B1UChA016203
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 11 Jul 2006 01:30:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k6B1UClE016202;
	Tue, 11 Jul 2006 01:30:12 GMT (envelope-from gnats)
Resent-Date: Tue, 11 Jul 2006 01:30:12 GMT
Resent-Message-Id: <200607110130.k6B1UClE016202@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Beyond Luo <fedora@ercist.iscas.ac.cn>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1242C16A4DA
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 11 Jul 2006 01:28:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7E5F643D68
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 11 Jul 2006 01:28:53 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k6B1SqLJ043307
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Jul 2006 01:28:52 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k6B1Sq0a043306;
	Tue, 11 Jul 2006 01:28:52 GMT (envelope-from nobody)
Message-Id: <200607110128.k6B1Sq0a043306@www.freebsd.org>
Date: Tue, 11 Jul 2006 01:28:52 GMT
From: Beyond Luo <fedora@ercist.iscas.ac.cn>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: kern/100045: [patch] mutex lock errors in drivers
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2006 01:30:13 -0000


>Number:         100045
>Category:       kern
>Synopsis:       [patch] mutex lock errors in drivers
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 11 01:30:11 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Beyond Luo
>Release:        6.0
>Organization:
Institute of Software, Chinese Academy of Science
>Environment:
FreeBSD Earth.Earth 6.0-RELEASE FreeBSD 6.0-RELEASE #2: Tue Feb 28 02:32:45 UTC 2006     root@guhao.fsd.iscas:/usr/obj/usr/src/sys/CAS-EARTH  i386
(We are doing some work on FreeBSD6.0)
>Description:
The following three files do not do mtx_unlock before return:
  /usr/src/sys/cam/scsi/scsi_cd.c (#line 594)
  /usr/src/sys/cam/scsi/scsi_da.c (#line 1004)
  /usr/src/sys/dev/aac/aac_cam.c (#line 417)

>How-To-Repeat:

>Fix:
  following mtx_unlock should be added respectively:
  mtx_unlock(&Giant);
  mtx_unlock(&Giant);
  mtx_unlock(&sc->aac_io_lock);
>Release-Note:
>Audit-Trail:
>Unformatted: