From owner-cvs-src@FreeBSD.ORG Sun Feb 11 22:55:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 97F5816A401; Sun, 11 Feb 2007 22:55:29 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 6332113C4A5; Sun, 11 Feb 2007 22:55:29 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (5fgh7dqsse6s41be@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l1BMtSix048929; Sun, 11 Feb 2007 14:55:28 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l1BMtSsc048928; Sun, 11 Feb 2007 14:55:28 -0800 (PST) (envelope-from jmg) Date: Sun, 11 Feb 2007 14:55:28 -0800 From: John-Mark Gurney To: Pawel Jakub Dawidek Message-ID: <20070211225528.GK1620@funkthat.com> References: <200702091903.l19J3Ik5099479@repoman.freebsd.org> <20070209211517.GI1620@funkthat.com> <20070210113451.GA15326@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070210113451.GA15326@garage.freebsd.pl> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, Brooks Davis , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/sun4v/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2007 22:55:29 -0000 Pawel Jakub Dawidek wrote this message on Sat, Feb 10, 2007 at 12:34 +0100: > On Fri, Feb 09, 2007 at 01:15:17PM -0800, John-Mark Gurney wrote: > > Brooks Davis wrote this message on Fri, Feb 09, 2007 at 19:03 +0000: > > > brooks 2007-02-09 19:03:18 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/conf GENERIC > > > sys/i386/conf GENERIC > > > sys/ia64/conf GENERIC > > > sys/pc98/conf GENERIC > > > sys/powerpc/conf GENERIC > > > sys/sparc64/conf GENERIC > > > sys/sun4v/conf GENERIC > > > Log: > > > Include GEOM_LABEL in GENERIC. It's very useful and not well publicized > > > enough. > > > > > > Approved by: pjd > > > > Can anyone think of a good place to put a warning about using labels > > along w/ gmirror? I've had a case recently where I was loading g_label, > > but forgot to load g_mirror... Since I was using ufs labels, my fs > > mounted perfectly fine, but was mounting only one part of the g_mirror.. > > I finally found this out when g_label decided to randomly use the other > > disk one boot... > > > > Maybe g_label should not expose duplicate labels? > > It only expose one of them - the one which comes first... > I'd prefer not to destroy existing provider when duplicated entry > appears. Imagine a situation where you have perfectly running system > with root mounted from /dev/ufs/root and at some point you insert > USB Pendrive with a UFS file system, which also has "root" label. > Do you really want the ufs/root provider from under your root file > system to be destroyed? Considering that the provider mounted as root has an exclusive bit set, you can easily detect this case, and not destroy it... In my case, both labels are unopened, and there are no open references to them... > Not loading gmirror was configuration mistake. I do want to protect > users against such mistakes, but in this situation I think the mistake I > described is more common or can be more problematic. And can easily be detected, and happens at a different point than the issue that I'm complaining about... > If you set kern.geom.label.debug to >= 1, glabel will print a warning: > > Label root(ufs/root) already exists (/dev/ad0s1a). > > (or something like that). We may consider printing it at the default > debug level (0) and see if there are not too many reports from the users > with false-positives. Printing a debug still doesn't prevent the automatic mounting and corruption of the mirror... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."