Date: Tue, 05 Nov 2019 02:32:15 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 241719] print/texinfo: fix NLS build, part 2 Message-ID: <bug-241719-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241719 Bug ID: 241719 Summary: print/texinfo: fix NLS build, part 2 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: sunpoet@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com Assignee: sunpoet@FreeBSD.org Flags: maintainer-feedback?(sunpoet@FreeBSD.org) After ports/r515761, the build now gets missing prototype warnings like so: parsetexi/api.c:74:7: warning: implicit declaration of function 'bindtextdomain' is invalid in C99 [-Wimplicit-function-declaration] bindtextdomain (PACKAGE, s); ^ parsetexi/api.c:89:5: warning: implicit declaration of function 'bindtextdomain' is invalid in C99 [-Wimplicit-function-declaration] bindtextdomain (PACKAGE, LOCALEDIR); ^ parsetexi/api.c:91:3: warning: implicit declaration of function 'textdomain= ' is invalid in C99 [-Wimplicit-function-declaration] textdomain (PACKAGE); There are a few problems involved: (a) The top level configure does not detect libintl.h, so it does not defi= ne HAVE_LIBINTL_H (because it doesn't look in /usr/local/include). (b) Even if it did set HAVE_LIBINTL_H (add USES=3Dlocalbase would do the j= ob), the configure that is run in tp/Texinfo/XS is different. It does not even = try to detect libintl.h and so it also does not set HAVE_LIBINTL_H. This means libintl.h is never included which triggers the compiler warnings. Thus, the change in ports/r515761 effectively just comment out the include = of libintl.h. An #if 0 would have done just as well. A fix for (a) is "NLS_USES=3Dgettext localbase" (instead of NLS_USES=3Dgett= ext). A fix for (b) is to teach tp/Texinfo/XS/configure(.ac) to look for libintl.= h - perhaps use the same method the top level configure uses. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241719-7788>