From owner-svn-src-all@FreeBSD.ORG Thu Sep 12 11:41:28 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4F0D5AE4 for ; Thu, 12 Sep 2013 11:41:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 148762BA2 for ; Thu, 12 Sep 2013 11:41:28 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8CBfR8D057989 for ; Thu, 12 Sep 2013 11:41:27 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8CBfRIu057984 for svn-src-all@FreeBSD.org; Thu, 12 Sep 2013 11:41:27 GMT (envelope-from bdrewery) Received: (qmail 85428 invoked from network); 12 Sep 2013 06:41:26 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 12 Sep 2013 06:41:26 -0500 Message-ID: <5231A85E.5050802@FreeBSD.org> Date: Thu, 12 Sep 2013 06:41:18 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Hiroki Sato Subject: Re: svn commit: r255486 - in head/lib/libc: gen sys References: <201309120053.r8C0rc7H082015@svn.freebsd.org> <20130912.203612.1272738297998644471.hrs@allbsd.org> In-Reply-To: <20130912.203612.1272738297998644471.hrs@allbsd.org> X-Enigmail-Version: 1.5.2 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pFAQXViDLLbN0OcEm32lMLaOSwXQrneB2" Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2013 11:41:28 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pFAQXViDLLbN0OcEm32lMLaOSwXQrneB2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 9/12/2013 6:36 AM, Hiroki Sato wrote: > Bryan Drewery wrote > in <201309120053.r8C0rc7H082015@svn.freebsd.org>: >=20 > bd> Author: bdrewery (ports committer) > bd> Date: Thu Sep 12 00:53:38 2013 > bd> New Revision: 255486 > bd> URL: http://svnweb.freebsd.org/changeset/base/255486 > bd> > bd> Log: > bd> Consistently reference file descriptors as "fd". 55 other manpage= s > bd> used "fd", while these used "d" and "filedes". > bd> > bd> MFC after: 1 week > bd> Approved by: gjb > bd> Approved by: re (delphij) >=20 > I think this kind of changes need a consensus because several POSIX > functions use "filedes" in the specification document. r254484 by > pjd was a similar change (s/type/af/ in gethostbyaddr()). >=20 > In SUSv4, fdopen() uses "filedes" and openat() uses "fd", for > example. Consistency throughout our manual pages is generally good. > However, I also see the benefit of using the same expression as the > specification even if it is inconsistent. What do you think? >=20 > -- Hiroki >=20 I did notice that 'filedes' was referenced in some specs, but it's very weird to open multiple manpages and expect 'fd' and find 'd' and rework my brain to understand that 'd' or 'filedes' is just a 'fd'. Takes a second of thinking. It was "surprising" to me when I noticed it, especially given how many used 'fd'. --=20 Regards, Bryan Drewery --pFAQXViDLLbN0OcEm32lMLaOSwXQrneB2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSMaheAAoJEG54KsA8mwz5UBIP/3YpaLiXokF1ulw0e8ABT32A RQ5tCf7Shr9R+ZkswKI7w+oIYM1tIX7p9N1/YWz6iUQdc+45WKzYIyFuB9GS2IJO x3AmKaBVL2BXjthAFaSDPzEi1PZVzJn6Xnzy2VfyUFVT/eaHtPLVuIyqB08hhhP3 zrSXc+BtVXFFBAplA8+pBzzFrywOX+B2XFldp7z6WTCV029gP0YTqgIfs/eQlIRR ZhSLi+iYDKkdAEyZAmrE8k2z2uCsRDCQdpBaIp+ir7XvME4LWI1T/GZvDkLU+uyP U9k2H7DNAvCAEwnOBOFTk08gNZpZS0fhMO5jfsYqFh8K7/8oXP8jIMh8lujKKCK2 3x0phkCKlHjYonPBo6N/JIbukwZnQse6JYe2FTaC8CH2iz6kVfYN2wUL66VdtI5W dPv3YQne4ZaZmtARypPQi64bmtQJqKh0Cq1R/Q0oyVSi1ujlpc5NH9qQd1ZP7vYu er6pwFq68JspZbr7zgAIwsPWuS+gy+4mBexhsC8ikKAA6zyvnTtjNo67rFGHYTu/ NMrvpOi3HuzIPLlxhfkURHYg5N6eehG7WjR8ttmidGICuCt5H/DJuLtATObOPaz1 tW1dP8u5VU1wkf2k9ODnQEl2BHdSzkJxPPL49d8j4zSKU91DAcMyMI1ILsoAkoAq kR84tNiVEXicRZxBnAie =IEXp -----END PGP SIGNATURE----- --pFAQXViDLLbN0OcEm32lMLaOSwXQrneB2--