From nobody Thu May 19 08:26:31 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1FD2C1ADF7BB; Thu, 19 May 2022 08:26:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L3jcm0JGlz4sl9; Thu, 19 May 2022 08:26:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652948792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AfDHw9b7bLHenWuNPbQsbi9k0qsrsuUvkUY5BLQ0ELo=; b=tI9YTcahicQIs8X0ZsVMUbzUZsgtBadqlgh289nXs3lASP19mleDPqgcUfSDzd7SBUfsWt 4zTAMokRMz9Y8iIahuLeWULxRLT9w/tZrpAAD3RhpsVJ6HIpBVLIr08P8mQlU+F5YEUzc5 b9wBEgs6njV2rjPWJNNP1mok9+n6whu6hH30pf6CGL8K5qkK/YDjB+p+iyAJOSU+WgjA0g 7ECXuFrR2TXGjWoSsh2880Gs2jpTo4Xp3foO6ekg7NqWdDGo1RPSIVA5opZN7EID1G85yZ GwjKtqzePLi/wrLqk0T7R1B3khv3WOSYK15x2sJar8EZhKlJcuus/PWDWakOtw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DABA41A49D; Thu, 19 May 2022 08:26:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 24J8QVk8068293; Thu, 19 May 2022 08:26:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 24J8QVEg068292; Thu, 19 May 2022 08:26:31 GMT (envelope-from git) Date: Thu, 19 May 2022 08:26:31 GMT Message-Id: <202205190826.24J8QVEg068292@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hans Petter Selasky Subject: git: ad7741ff693a - main - ibcore: Fix possible memory leak in ib_mad_post_receive_mads() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad7741ff693a39bab59b75e432bd922a62f3ef0a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652948792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AfDHw9b7bLHenWuNPbQsbi9k0qsrsuUvkUY5BLQ0ELo=; b=Y/5fulK5tvI4l2qNZE0BXNwPcvlm3v61Ty05ExjuXCNh4dZH4zVsAGDDLR6uPznOX/tuor Sv65+ZCEWwmxbSRpyvHIIZQzk42mNclyPVkQuCe8R0a2SBwr8+JHwEzHtYmVpBaD3ezyb4 YkAseYgaAEURn5TDshhFdAF4kNFDwiF77jIwZzc1U/EwPIW7Ts+2t8SPWtJNEwgcb1D5tR TXu6EHizwNhKYvzo8Qzy2KYKBYj8b7cmqCPwR1yOvQ3f7c9nbeiHSrokpRXRv+S/UAwYtz QOKg7dsKk5LzJ2oysJGIVdsYfhhGRyBYjvq6UerrKpFoWdT33ZC+lzCaZ3ED9Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652948792; a=rsa-sha256; cv=none; b=Q1e7tzLcY0Dnkn7A6RzQxqjPbGfnQJqBYCGLPstq7VYeuXjX2QwhDzBy/W03XAjC2y4TX1 jEDj9P9yUVsHITjc/n2bIb4tPEo03sOm136FeAI35JRLH3AH+Oj1uQNnYgs9x6ELPY78IN f9idYpwM0paLwtqbLgjEakI2lnL050CF58HuK0cRlGai55qkcX9cj8o0TDE+fF6XkvCFB5 u6YZaeFndZgWpu708lm1U7bI+rEeHxR0b9knjdQmlmIKLCIbZcLW98M37tTzS0M+cQED+t LRPAr57keSxcKrV6G5yqoii4cR4OI4BsRRDDt+/M91HrmxxRr+sVtrrrMwnIsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=ad7741ff693a39bab59b75e432bd922a62f3ef0a commit ad7741ff693a39bab59b75e432bd922a62f3ef0a Author: Hans Petter Selasky AuthorDate: 2022-05-19 08:06:42 +0000 Commit: Hans Petter Selasky CommitDate: 2022-05-19 08:13:06 +0000 ibcore: Fix possible memory leak in ib_mad_post_receive_mads() If ib_dma_mapping_error() returns non-zero value, ib_mad_post_receive_mads() will jump out of loops and return -ENOMEM without freeing mad_priv. Fix this memory-leak problem by freeing mad_priv in this case. Linux commit: a17f4bed811c60712d8131883cdba11a105d0161 PR: 264057 MFC after: 1 week Sponsored by: NVIDIA Networking --- sys/ofed/drivers/infiniband/core/ib_mad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/ofed/drivers/infiniband/core/ib_mad.c b/sys/ofed/drivers/infiniband/core/ib_mad.c index 5f9c353052e8..9de97d749f6d 100644 --- a/sys/ofed/drivers/infiniband/core/ib_mad.c +++ b/sys/ofed/drivers/infiniband/core/ib_mad.c @@ -2874,6 +2874,7 @@ static int ib_mad_post_receive_mads(struct ib_mad_qp_info *qp_info, DMA_FROM_DEVICE); if (unlikely(ib_dma_mapping_error(qp_info->port_priv->device, sg_list.addr))) { + kfree(mad_priv); ret = -ENOMEM; break; }