From owner-freebsd-hackers@FreeBSD.ORG Wed Jul 16 17:46:47 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D658A7F0; Wed, 16 Jul 2014 17:46:47 +0000 (UTC) Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A8A2920C2; Wed, 16 Jul 2014 17:46:46 +0000 (UTC) Received: from localhost (mail.ixsystems.com [10.2.55.1]) by mail.iXsystems.com (Postfix) with ESMTP id D6AC77A568; Wed, 16 Jul 2014 10:46:45 -0700 (PDT) Received: from mail.iXsystems.com ([10.2.55.1]) by localhost (mail.ixsystems.com [10.2.55.1]) (maiad, port 10024) with ESMTP id 32494-06; Wed, 16 Jul 2014 10:46:45 -0700 (PDT) Received: from kruse-177.4.ixsystems.com (kruse-177.4.ixsystems.com [10.2.4.177]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTPSA id 4B4397A563; Wed, 16 Jul 2014 10:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ixsystems.com; s=newknight0; t=1405532805; bh=HIsTcNj9+gXJYv6fwdgT6/XBNodl3e7Q7LLkZuR5+6g=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=Nq9aCVE1O0+HzkSgICB/u5lDuXG4h9uR5cA26z8BuCpa6uNxuha6FP8puOalsUDFj ppqFtQnqm7t24URMZ7QjIsOyeRHAfMp49XAXvUl6LV6IBal4FXkHBs5oQrfU2edeRQ 1cbSrk1zNgE8kti7AuXpBGoMRoze7as/J+4ib10M= Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Expanding on NO_ROOT: Categorizing installed files From: Sean Fagan In-Reply-To: <20140716170758.GE60425@spindle.one-eyed-alien.net> Date: Wed, 16 Jul 2014 10:46:44 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20140716170758.GE60425@spindle.one-eyed-alien.net> To: Brooks Davis X-Mailer: Apple Mail (2.1878.6) Cc: hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 17:46:47 -0000 On Jul 16, 2014, at 10:07 AM, Brooks Davis wrote: > The vast majorify of the diff is make debugging garbage that looks = like > it was committed by accident. I won't provided any detailed review > of the current patch except to say that there are a lot of apparently > redundent instances of setting META_CATEGORY in Makefiles and still > quite a lot of instances of .EXPORTVAR: META_CATEGORY. There were ten. I've removed those (and the make debug out, and a stray .orig file, grrr), and am testing now. That'll take a while ;). >> I have not changed it from having a new "category=3D" to using = "tag=3D"; I looked at that, and don't think it's the best way to go, but = am still looking. >=20 > Given that the current use of tags=3D is basically unconsumed, I still > don't understand why. First, because the space is limited -- it's not "tag type=3Dvalue", but = "tag=3Dvalue". So if there is a category of "debug", that conflicts = with a tag of "debug." And similarly for any other tags. Second, because "category=3D" isn't the only keyword I might want to add = here -- I would prefer that the metalog be considered a key-value = sequence, and any consumer should simply ignore any key it doesn't = understand. (Consider checksums, as a semi-obvious example of one that can be put in = place by install.) Combine the two, and I'm very wary of it -- it puts a limitation in, = when it should be extensible. Sean.=