From owner-svn-src-head@freebsd.org Tue Jan 19 20:05:25 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0FC22A88834; Tue, 19 Jan 2016 20:05:25 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CE0531A37; Tue, 19 Jan 2016 20:05:24 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x233.google.com with SMTP id 1so546078574ion.1; Tue, 19 Jan 2016 12:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=aDa5q0CRjkoyVUeQY5celKGz7F/rhJfTFNFaSVoVNWM=; b=pG9/CrdRa2topMA7Dr+9B7n6sR1dLoS3pQGQmAsGchwyIiL2tw/DkfW0YNIKYhZnzD pTV1tJuVJwT5D0jl8CLOy3SYRzDYUMiZlsFT1wNsDqMSs8xa6ESnp+cYlcGTGpTEVHLH G3gXNDKCodwS8tcH+oatSJakYnlX68XOJRQEp6p0AtacV32ZXwqb5lyNZF33Doz2tidq 4rEMdrv9N4XUCh+Gl0ZMhZnikOXNgGaOFzpcwZUAhdYGRtzTZ+d0V7jB/5UEiB2hsaLi 6mTGDhfqVD0Wx3tTEA5UNaF+dDQUwvRKDw3vtpxI9nyNf9Sel7soFhs05sb8bJ6egASK uOSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=aDa5q0CRjkoyVUeQY5celKGz7F/rhJfTFNFaSVoVNWM=; b=mNlgYFGedUfMOPv5uEKTeBnpsF9JJ3CCMsZFxRtzXjiEpTuhvhD61EyrltSAm6wjvS HSl8k+x38rd/h2a0v0/yI7xAhUbTl4ZQdlrGyiH33/azn9s632wnOzLFJZ4KW9FG6jSP DkmiJjnA9RyHqr121hiFl2EH807wMPgAIsCM58F5eBQ+O/wQ8KYuCA7KGLCIYJEK5J96 DuZR8TBVw1KKrOHXj7WfPKLPDzOnGOd7SQ+sV5fhLuEbsibbrocL5YQbET5vdWz8bPz3 TYRCww7TiM+iNkdWgRhaRTDM6YPYhqNaRMOUnJzeVJ9jNiR2KMfvYqGZ81DQbkiA5VrX XB0w== X-Gm-Message-State: ALoCoQmzonFLD3v1MRwiNSxQ+Z52GXZuB0BP3COBXaF7ghG3eQ5G2ZYIq2bM81YeVAbdb6aBpKQMvmTbqacYFtgTRBlthhtp5g== MIME-Version: 1.0 X-Received: by 10.107.10.217 with SMTP id 86mr27523594iok.75.1453233924329; Tue, 19 Jan 2016 12:05:24 -0800 (PST) Received: by 10.36.121.16 with HTTP; Tue, 19 Jan 2016 12:05:24 -0800 (PST) In-Reply-To: <569E909B.60506@selasky.org> References: <201601191533.u0JFXSxf037804@repo.freebsd.org> <569E6A38.8080108@selasky.org> <569E909B.60506@selasky.org> Date: Tue, 19 Jan 2016 12:05:24 -0800 Message-ID: Subject: Re: svn commit: r294327 - in head/sys: dev/cxgb dev/cxgbe dev/e1000 dev/hyperv/netvsc dev/ixgbe dev/mxge netinet sys From: Adrian Chadd To: Hans Petter Selasky Cc: Ryan Stone , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 20:05:25 -0000 Erm, ok. So I'm confused about the state of how the streams are tracked. So not all mbufs are in a stream, but they're in some single LRO mbuf list? -adrian On 19 January 2016 at 11:38, Hans Petter Selasky wrote: > On 01/19/16 20:26, Adrian Chadd wrote: >> >> Well, why are you using qsort to do it, rather than walking the list >> of streams and inputting all the mbufs per stream? >> >> That's an O(1) operation. >> > > Because you don't know when the stream ends and then you'll need to pass the > list one time for every stream which is O(N*N) :-) > > --HPS >