Date: Fri, 6 Dec 2013 22:25:17 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Nikolai Lifanov <lifanov@mail.lifanov.com> Cc: Devin Teske <dteske@freebsd.org>, freebsd-stable stable <freebsd-stable@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com>, "freebsd@skysmurf.nl" <freebsd@skysmurf.nl> Subject: Re: [games/ofortune] CFT and pending issues Message-ID: <A64631EB-A272-4299-8565-20CB1B8874BD@fisglobal.com> In-Reply-To: <89649111-31D9-42AE-BD92-A715F10D37A3@fisglobal.com> References: <52A1E05A.10904@mail.lifanov.com> <89649111-31D9-42AE-BD92-A715F10D37A3@fisglobal.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 6, 2013, at 2:22 PM, Teske, Devin wrote:
>
> On Dec 6, 2013, at 6:34 AM, Nikolai Lifanov wrote:
>
>>> -1-
>>> It's tentatively called ofortune. If you can think of a better name, >
>>> then
>>> by all means shoot.
>>
>> How about fortune-offensive?
>> I suggest putting new fortunes in /usr/local/games/fortune.
>> You can install /usr/local/bin/fortune, which is a shell script with
>> roughly this content:
>>
>> #!/bin/sh
>> env FORTUNE_PATH=/usr/local/games/fortune:/usr/games/fortune $@
>>
>
> Useless use of an "env" ;D
Oh, and that syntax will negate the ability to override the value.
Oh, and the unquoted $@ will exhibit unexpected behavior.
Better would be:
#!/bin/sh
FORTUNE_PATH="${FORTUNE_PATH:+$FORTUNE_PATH:}/usr/local/games/fortune" "$@"
--
Devin
_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A64631EB-A272-4299-8565-20CB1B8874BD>