From owner-svn-src-head@freebsd.org Wed May 3 19:38:41 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C3F2D58491; Wed, 3 May 2017 19:38:41 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x229.google.com (mail-yw0-x229.google.com [IPv6:2607:f8b0:4002:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 265E5181C; Wed, 3 May 2017 19:38:41 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x229.google.com with SMTP id 203so90354306ywe.0; Wed, 03 May 2017 12:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0lmgdPs5X5Pdx6T89X27rCqmdL1D0AnOA+V5H5iz2ug=; b=p8Gb3wSFLr3GCeAlQG8D7DYIRqPH+I0RUBqQJwnz4P92EQhkMyExlUYDg+TuO5HKvZ ehK3jTL9IjXYU0crq9V4oMbT6+CWqa0FIP9QEjVIuB7YKCbPJnqw+6ycNbhJxCX6gqz4 TzipXKYX2R1G8YQ78bvCkpUR3u5Fv4MtJ5H0NvW1Jh3UoxsSLlY7q/+dxgjvPK9jUvSl mnGjPTFrudHAC9MDMHYo7ScWl2Yt8iro4JWJ/bfBPRg/+XCQGnBNGLB/bSOb6WoaZkJb kB2MX3ouk9m8WMg3Z4CcuF8fQ+YIlcZme3kDbbF7Q3MtC3vyDvWbCltofKGkvahr5Q43 2f/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0lmgdPs5X5Pdx6T89X27rCqmdL1D0AnOA+V5H5iz2ug=; b=kl63MjM2rsGuClBrGcnFBa7Fe79SLjSbDUiCnnTkmvgU3QrlmNAQp2jaQ+stZwhKpd m/n++FEhoPodtDDOOKHTAqI1SbhqWXbBBDDMl8zgUF573sVHnNIOdrzsa8mn0WZfyBCk gSoofkrSldpmvNp5C5eQtj9+JniezwCwiw0G//3Vq4OgBE0a9ekcqjEFp2zerTGYf1Oi 5ksbyRPQ2WnUR/433uR2vWtXH/3FeWcrRsFFCDEDfUiS73/Z5Y1jDNG3wZzhDcxzrNP0 QBFwGzE4llsA2wgFDA/Y3cXZrac8D4RlbRb4oMYYWVQ0C2dYpahpjAJtgerSLW71OFtR UP+Q== X-Gm-Message-State: AN3rC/6JStEiVqe7bIP98ftlOe8gRKSmXQEraqvADJf8A4fFRxpJd8Nr mkQ0uvXQpXwdOAppkJcGteIj4s3c2g== X-Received: by 10.129.4.151 with SMTP id 145mr30509388ywe.222.1493840320241; Wed, 03 May 2017 12:38:40 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.20.214 with HTTP; Wed, 3 May 2017 12:38:39 -0700 (PDT) In-Reply-To: References: <201705031721.v43HL2vS071819@repo.freebsd.org> <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> From: Alan Somers Date: Wed, 3 May 2017 13:38:39 -0600 X-Google-Sender-Auth: 5kPF3Ujp1rvIo_Qw6CFdSmieowE Message-ID: Subject: Re: svn commit: r317755 - head/sbin/ifconfig To: Warner Losh Cc: Ngie Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 19:38:41 -0000 On Wed, May 3, 2017 at 1:34 PM, Warner Losh wrote: > On Wed, May 3, 2017 at 1:32 PM, Alan Somers wrote: >> On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper wrote: >>> >>>> On May 3, 2017, at 10:21, Alan Somers wrote: >>>> >>>> Author: asomers >>>> Date: Wed May 3 17:21:01 2017 >>>> New Revision: 317755 >>>> URL: https://svnweb.freebsd.org/changeset/base/317755 >>>> >>>> Log: >>>> Various Coverity fixes in ifconfig(8) >>> >>> ... >>> >>>> * Mark usage() as _Noreturn (1305806, 1305750) >>> >>> ... >>> >>>> -static void usage(void); >>>> +static void usage(void) _Noreturn; >>> >>> Hi Alan, >>> Please use __dead2 instead to be consistent with legacy use of similar gcc attributes. >>> Thanks, >>> -Ngie >> >> Why not use _Noreturn? It's standardized by C11, so tools understand >> it better than __dead2. > > Tools that can't understand #define __dead2 _Noreturn aren't worth supporting. > > Warner Some tools don't expand preprocessor macros. Like my editor, for example, which highlights _Noreturn as a keyword but not __dead2. -Alan