Date: Thu, 21 Oct 2010 14:30:08 -0400 From: John Baldwin <jhb@freebsd.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214144 - head/sys/vm Message-ID: <201010211430.08219.jhb@freebsd.org> In-Reply-To: <20101021181921.GG77125@hoeg.nl> References: <201010211729.o9LHTXEv098032@svn.freebsd.org> <20101021181921.GG77125@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, October 21, 2010 2:19:21 pm Ed Schouten wrote: > Hi John, > > * John Baldwin <jhb@FreeBSD.org>, 20101021 19:29: > > + if (atomic_fetchadd_int(&vm->vm_refcnt, -1) == 1) > > vmspace_dofree(vm); > > Not that it's that useful, but maybe it would be good to use > refcount_release() here? Not in this case because the other places do not use the refcount API. Specifically, the code in vmspace_exit() is a bit tortuous. I'd rather code only use the refcount API if it is going to always use it. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010211430.08219.jhb>