From owner-freebsd-fs@FreeBSD.ORG Tue Oct 2 12:52:01 2007 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9417216A468 for ; Tue, 2 Oct 2007 12:52:01 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 259E613C458 for ; Tue, 2 Oct 2007 12:52:00 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id A986845F45; Tue, 2 Oct 2007 14:51:58 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 0314745F43; Tue, 2 Oct 2007 14:51:51 +0200 (CEST) Date: Tue, 2 Oct 2007 14:51:48 +0200 From: Pawel Jakub Dawidek To: db Message-ID: <20071002125148.GI1693@garage.freebsd.pl> References: <4700A791.6020606@encephalon.de> <20071001091106.GB35764@garage.freebsd.pl> <4700BC65.1000303@encephalon.de> <4700BE80.5080109@encephalon.de> <4700C441.30100@nipsi.de> <861wcf82p3.fsf@ds4.des.no> <4700E97A.1040704@nipsi.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LHvWgpbS7VDUdu2f" Content-Disposition: inline In-Reply-To: <4700E97A.1040704@nipsi.de> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org, Dag-Erling Sm??rgrav Subject: Re: zpool does not work X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 12:52:01 -0000 --LHvWgpbS7VDUdu2f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 01, 2007 at 02:35:06PM +0200, db wrote: > Dag-Erling Sm??rgrav schrieb: > >db writes: > > =20 > >>We reported this months ago... :-( > >> > >>http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104389&cat=3D > >> > >>could someone please verify and commit this fix? > >> =20 > > > >Both patches in the PR are incorrect. The second patch is better than > >the first, but still gets the logic wrong and completely misses the > >point of using an sbuf in the first place. > > > >DES > > =20 > I meant this one > http://www.freebsd.org/cgi/query-pr.cgi?prp=3D104389-3-diff I fully agree that this should be fixed, but you should use sbuf() directly instead of sprintf()s. Could you another patch with this fixed? It will also eliminate direct memory allocation. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --LHvWgpbS7VDUdu2f Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHAj7kForvXbEpPzQRAv/MAJwJ7b6Y5x92t1kwJC1VsoPAE5JqigCeMo5K gIx1Ye6aHLewM5oRNWHQBrY= =UZ2k -----END PGP SIGNATURE----- --LHvWgpbS7VDUdu2f--