From owner-cvs-all Wed Apr 11 5: 1: 4 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id C88B637B423; Wed, 11 Apr 2001 05:00:59 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA31890; Wed, 11 Apr 2001 22:00:56 +1000 Date: Wed, 11 Apr 2001 21:59:03 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: John Baldwin Cc: Kirk McKusick , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Brian Somers Subject: Re: cvs commit: src/bin/ps ps.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 10 Apr 2001, John Baldwin wrote: > [ more to Brian than to Kirk ] > If all that is needed is a uniquifier for sessions, then why not use > the actual session ID itself: s_sid? It's already provided in > kinfo_proc as ki_sid even, ps(1) just doesn't use it at the moment. > That is probably much easier to parse than a kernel address. I agree that this would be better. In fact, Kirk added both ki_sid and ki_tsid. He apparently just forgot to actually use them :-). I think pstat should also print the session ID instead of the session pointer. This would take a bit more work to implement (a sysctl returns a `struct tty' for each tty, and this struct only contains the [t]session pointer). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message