From nobody Tue Feb 3 14:05:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f54xZ51mTz6PcKY for ; Tue, 03 Feb 2026 14:05:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f54xZ3GHSz3jy5 for ; Tue, 03 Feb 2026 14:05:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770127506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZiiFcfgnj4j6HgVDBry6vl7/AdCInHVzUMzH2ClmWPI=; b=rvkbdWgPFbRXf9QlTzZcJPdFfcI77eeKhWRzTQObdTX0czea+3nEd+kkc5e+CitNXgKOnR 08Wo/WazCGN9dy6Z1Ie16+bzbpKhY2vgPTt6YE+S2Wl+YfJp65LsxZ4Fcl2fjhiY2eKQU7 RoE3GOFWGmGYyqjho/W3/P8kAO2etzDCBxMKnsMXIIxjbGJYcMpg/Wgd8RvAz8lhMqUC6G J+Vf7rKsX9jAe339OVP0caRvKEclKsnhcuMlsqhmhNcyPVlrEsvcDoEmkPaj5Dhvthm3tl QjMJzjaiKyeTtDZtMB4Aarn7g8ifwiJ4xm0JJS63/NVfxqt7QarVWiTX3Dnz/g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770127506; a=rsa-sha256; cv=none; b=aybaBww/LhFHo3e2N0S4+XF6VZArsb8lKbiQeWmaqJVQyVhWLNdCqQTYbbCmnjzsSHPh+C skgLr7Qw7ZU1qIXAytKjZ8o3kWc/mR108EghpY34JCQw/mJOeXnXnmz0SvYVSsgvET4KKJ ExCpkv4rLEpW9vBriRUHRYwi6E7txiAnAXtcQ13SOpAHk11tfPfFGF3Y7mHO0ZzvBhAjqP kFKVKtoyP69uqktFLkOObHj+InrqOmHnsEr2JKGpNo/jeG3CW8evYW52H78p1qw5236N6Y 9USY13tgEwLXxyVPX4PHPAkPJgw310vS28VBgY/Ba/JkY3K+beoYPaA883ExbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770127506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZiiFcfgnj4j6HgVDBry6vl7/AdCInHVzUMzH2ClmWPI=; b=uceM1IJnb7Vxakhl3POcchZOVhtIcQyPspyz0AvgoxvzeiWWOR+T0oQurVwyY/bI+B46Y/ 8S0kZEW0p0BeMoA5kLcD9NZF6dpnxaygtslho5Io8GFD93sRCjfHoPY5nf15WjS1Vsx/k+ WkUkR0nhj4rBlDVarXYnEbbF7FyL8tcJPje00CUjn0y+wakSLpv6GLKFBcp1sPMTaJIQW3 CdFT00C34zi5ghAY3Ft0E6hVyZyXppqWPu/K3mFDS5icBmncLKeYlHtjGwVmqa1mNTeV8b aQONY+R1L72hDm71X0eqEYzSMIQ3KKp88UO6k7umaHLkkhIkdR0719dyZ4CLRw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f54xZ2YGRz1pT for ; Tue, 03 Feb 2026 14:05:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3af07 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Feb 2026 14:05:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 4b0e09a918fb - main - hwpstate_amd(4): Fix BITS_WITH_VALUE()/SET_BITS_VALUE() to obey the mask List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4b0e09a918fbcdb3938ecb8e0efc3313bd3b2308 Auto-Submitted: auto-generated Date: Tue, 03 Feb 2026 14:05:06 +0000 Message-Id: <69820092.3af07.37153790@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=4b0e09a918fbcdb3938ecb8e0efc3313bd3b2308 commit 4b0e09a918fbcdb3938ecb8e0efc3313bd3b2308 Author: Olivier Certner AuthorDate: 2026-01-29 09:00:02 +0000 Commit: Olivier Certner CommitDate: 2026-02-03 14:03:02 +0000 hwpstate_amd(4): Fix BITS_WITH_VALUE()/SET_BITS_VALUE() to obey the mask While here, rename an argument of BITS_VALUE() to be consistent with the other macros. Reviewed by: aokblast Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D54997 --- sys/x86/cpufreq/hwpstate_amd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/x86/cpufreq/hwpstate_amd.c b/sys/x86/cpufreq/hwpstate_amd.c index 34838753e221..08c833d1a2dd 100644 --- a/sys/x86/cpufreq/hwpstate_amd.c +++ b/sys/x86/cpufreq/hwpstate_amd.c @@ -115,9 +115,11 @@ #define HWP_AMD_CLASSNAME "hwpstate_amd" -#define BITS_VALUE(bits, num) (((num) & (bits)) >> (ffsll((bits)) - 1)) -#define BITS_WITH_VALUE(bits, val) ((uintmax_t)(val) << (ffsll((bits)) - 1)) -#define SET_BITS_VALUE(var, bits, val) \ +#define BITS_VALUE(bits, val) \ + (((val) & (bits)) >> (ffsll((bits)) - 1)) +#define BITS_WITH_VALUE(bits, val) \ + (((uintmax_t)(val) << (ffsll((bits)) - 1)) & (bits)) +#define SET_BITS_VALUE(var, bits, val) \ ((var) = ((var) & ~(bits)) | BITS_WITH_VALUE((bits), (val))) #define HWPSTATE_DEBUG(dev, msg...) \