From owner-svn-src-all@FreeBSD.ORG Tue Apr 21 18:52:09 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 679D91065678 for ; Tue, 21 Apr 2009 18:52:09 +0000 (UTC) (envelope-from stas@SpringDaemons.com) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id D18AE8FC13 for ; Tue, 21 Apr 2009 18:52:08 +0000 (UTC) (envelope-from stas@SpringDaemons.com) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id D9E178FC4F for ; Tue, 21 Apr 2009 22:52:06 +0400 (MSD) Received: from sputnik.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id 18A3F8FC18; Tue, 21 Apr 2009 22:52:05 +0400 (MSD) Received: by sputnik.SpringDaemons.com (Postfix, from userid 1024) id 59F50B86F; Tue, 21 Apr 2009 22:54:05 +0400 (MSD) Date: Tue, 21 Apr 2009 22:54:04 +0400 From: Stanislav Sedov To: "M. Warner Losh" Message-Id: <20090421225404.5c83c32c.stas@FreeBSD.org> In-Reply-To: <20090421.123847.70203894.imp@bsdimp.com> References: <20090421220138.f6e7b4d4.stas@FreeBSD.org> <20090421.121805.-1954387331.imp@bsdimp.com> <20090421223502.507f0dcf.stas@FreeBSD.org> <20090421.123847.70203894.imp@bsdimp.com> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprin: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Innocent X-DSPAM-Processed: Tue Apr 21 22:52:06 2009 X-DSPAM-Confidence: 0.9899 X-DSPAM-Improbability: 1 in 9809 chance of being spam X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 49ee15d6967005859719820 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191322 - in head/sys: arm/conf dev/iicbus X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 18:52:10 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 21 Apr 2009 12:38:47 -0600 (MDT) "M. Warner Losh" mentioned: > In message: <20090421223502.507f0dcf.stas@FreeBSD.org> > Stanislav Sedov writes: > : -----BEGIN PGP SIGNED MESSAGE----- > : Hash: SHA1 > : > : On Tue, 21 Apr 2009 12:18:05 -0600 (MDT) > : "M. Warner Losh" mentioned: > : > : > In message: <20090421220138.f6e7b4d4.stas@FreeBSD.org> > : > Stanislav Sedov writes: > : > : -----BEGIN PGP SIGNED MESSAGE----- > : > : Hash: SHA1 > : > : > : > : On Tue, 21 Apr 2009 09:25:05 -0600 (MDT) > : > : "M. Warner Losh" mentioned: > : > : > : > : > In message: <200904201547.n3KFl6Z6050834@svn.freebsd.org> > : > : > Stanislav Sedov writes: > : > : > : Author: stas > : > : > : Date: Mon Apr 20 15:47:06 2009 > : > : > : New Revision: 191322 > : > : > : URL: http://svn.freebsd.org/changeset/base/191322 > : > : > : > : > : > : Log: > : > : > : - Give a warning and start the oscillator if it was not previously > : > : > : runned. > : > : > : - Rename ds1672 -> rtc to follow the other drivers. > : > : > > : > : > This is a bad change. Please back it out. There are multiple > : > : > different kinds of rtc clocks that can live on i2c. > : > : > > : > : > : > : Why do you want to? We already have ds133x under the same name. In case > : > : if there're multiple clocks in the same systems the first one will > : > : have the name of rtc0, the second - rtc1 and so on. > : > > : > Because you'll want to support a range of boards that might have > : > multiple different kinds of rtc i2c clocks. Calling them all i2c > : > won't work because you can't probe the i2c bus in any meaningful way. > : > the ds133x one, if it is named rtc, is wrong too. > : > > : > : I still don't fully see your point. If you have two different RTCs > : sitting on I2C bus they either have a different address, or they're > : attached to different rtc busses. So you can configure them in a > : usual way via hints. > > You don't see my point, that's right. > > Consider one kernel. Two different boards. Different RTC chips on > each of these boards. Hints loaded from the boot loader. Now, on one > board the ds1672 is used, on the other a ds163x is used. How does the > right driver get attached in that case? > Ah, you're right. I'll revert that change in both drivers. Thanks for clearing this out. - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAknuFk0ACgkQK/VZk+smlYFqWACdEalM/70f8cI7YiSugRFVDrgd oAoAn3Jm5PzpGMj8QfcXZonnNsbEHWhu =ilyh -----END PGP SIGNATURE----- !DSPAM:49ee15d6967005859719820!