Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Oct 2017 14:04:53 +0000
From:      Glen Barber <gjb@FreeBSD.org>
To:        Hiroki Sato <hrs@FreeBSD.org>
Cc:        doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org
Subject:   Re: svn commit: r51055 - head/en_US.ISO8859-1/htdocs/releases/12.0R
Message-ID:  <20171023140453.GE95482@FreeBSD.org>
In-Reply-To: <20171022.202023.700298682654760426.hrs@allbsd.org>
References:  <201710052007.v95K7wdI038021@repo.freebsd.org> <20171022.202023.700298682654760426.hrs@allbsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--6Vw0j8UKbyX0bfpA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 22, 2017 at 08:20:23PM +0900, Hiroki Sato wrote:
> Glen Barber <gjb@FreeBSD.org> wrote
>   in <201710052007.v95K7wdI038021@repo.freebsd.org>:
>=20
> gj> Author: gjb
> gj> Date: Thu Oct  5 20:07:58 2017
> gj> New Revision: 51055
> gj> URL: https://svnweb.freebsd.org/changeset/doc/51055
> gj>
> gj> Log:
> gj>   Reapply r51054, with a few fixes.
> gj>   Fix a typo: s/elfi/elif/
> gj>   Remove dependencies from the dev-auto.ent target, which seems
> gj>   I misread the original version of how this was invoked.
> gj>
> gj>   Sponsored by:	The FreeBSD Foundation
>=20
>  These part should be in hardware/ directory and a part of guessing
>  MAN4DIR should be dropped.  MAN4DIR must be specified because each
>  hardware directory is for a specific branch/release as I pointed out
>  in another email.  A generic location such as src/share/man/man4 or a
>  guessed directory is confusing.
>=20
>  Makefile does not handle cross-directory dependency well, so
>  dev-auto.ent should be generated in the hardware directory.
>=20
>  Also, please do not use <lang>/htdocs/share.  Common files should be
>  in head/share or head/<lang>/share consistently.
>  releases/12.0R/share/xml needs some more consideration, but I think
>  it is fine for now.
>=20
>  A patch to fix generation of hardware notes and other minor nits is
>  attached.  Note that XML catalog resolution is still broken.
>=20

Thank you for the feedback.  I will try to look at this today, but if it
just works for you, please go ahead and commit it.  One thing to note is
SUBDIR was originally not used, as a faster way to get the install path
correct for files like relnotes.html and hardware.html, so the structure
did not change on the website.  I cannot tell after a quick glance if
this behavior persists with the attached patch.

Glen


--6Vw0j8UKbyX0bfpA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEVVuz/A7vpH93hEhKuWzd6q+LXtAFAlnt9wUACgkQuWzd6q+L
XtBUihAA02BWfAZgNej2MEWCUjypaDr2MbX+q9ENNiJh8dgeoaZgN5I2LxmQ40Sx
5qOBmAn83u+oFhCb+ZzdL7+ZkopeFtw0XSiIIRP7KGzVPLxmi1+65HWkBA6X3aAZ
rHgjZD8osqHHhZNKcblfTVyxON67yCvB42PPLsTCUMF7todDwGByy9G+gAzK+CzM
auahm7s1MANb05zJGCCsGW2ESpUn6YoLji+gxPUaM7fqx/tWwSIMVxNDcSZdtxKo
HFYNO7o4WC4tfgrVv1uxRz/lkRPtR7+5cvs4X7hUYDr3GFAtGB6aYjVAhm/0xvd3
nX9BlTxlTKXI5YysEv59TO4Dr+ML4luzo55QVbd97edSsmE0xznQj8XJTEDawUS3
Yaot7ybA2XXIQnDDpU0BIHcehsALj/aArIXk9oK1YtjOqLXJ4337Pb3qFCo54TcS
goK5nkylp6mqQXCnYdljHfh9AktVnSVBqTv3Bnq/xk7GeTsZwGq8vBfRNa0Fh60y
MZJeqnUy1Git+upz+3cQvu8ZAefa9q1V1ti1WS7UewY6gHPJ6G9a3CZpUSclftSH
/sqqnUKinXFdl6S52xsFb6WVwEUD1dX/1kPKb4ytTbKT8Q6e0l+3yiE4Ntyfvuuw
mLAVy89j5yzjtn/6PIB/dSqNsiQ4QF866W3I2EdYA2yxnChRlkQ=
=QS+2
-----END PGP SIGNATURE-----

--6Vw0j8UKbyX0bfpA--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171023140453.GE95482>