From owner-freebsd-hackers@FreeBSD.ORG Wed Jul 16 19:13:51 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B7E938D for ; Wed, 16 Jul 2014 19:13:51 +0000 (UTC) Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4521628DD for ; Wed, 16 Jul 2014 19:13:50 +0000 (UTC) Received: from localhost (mail.ixsystems.com [10.2.55.1]) by mail.iXsystems.com (Postfix) with ESMTP id AFFE97B064 for ; Wed, 16 Jul 2014 12:13:49 -0700 (PDT) Received: from mail.iXsystems.com ([10.2.55.1]) by localhost (mail.ixsystems.com [10.2.55.1]) (maiad, port 10024) with ESMTP id 41535-03 for ; Wed, 16 Jul 2014 12:13:49 -0700 (PDT) Received: from kruse-177.4.ixsystems.com (kruse-177.4.ixsystems.com [10.2.4.177]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTPSA id 3A2827B05F for ; Wed, 16 Jul 2014 12:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ixsystems.com; s=newknight0; t=1405538029; bh=dS6dCgTtf15Uld4wNZ1rEoIGF7+//psZ1a7BkDnU32s=; h=Subject:From:In-Reply-To:Date:References:To; b=BVBj9/UsAyBQzSPpEJNXngF9wusyZFygy6+nmC/vQs9iyUFxXA98n5bc6NJU0wl5u Oapu6Z4mEt6lbPWOQCtbvn1qYTi+kDuGMWFYQov44JMOT6A7AMnOJXTDeyLw36oVRa ABSNcW7gsWQWy4y8WYwoYcpxKi1bZ4tndmmItI8Q= Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Expanding on NO_ROOT: Categorizing installed files From: Sean Fagan In-Reply-To: <20140716170758.GE60425@spindle.one-eyed-alien.net> Date: Wed, 16 Jul 2014 12:13:48 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20140716170758.GE60425@spindle.one-eyed-alien.net> To: hackers@freebsd.org X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 19:13:51 -0000 On Jul 16, 2014, at 10:07 AM, Brooks Davis wrote: > The vast majorify of the diff is make debugging garbage that looks = like > it was committed by accident. I won't provided any detailed review > of the current patch except to say that there are a lot of apparently > redundent instances of setting META_CATEGORY in Makefiles and still > quite a lot of instances of .EXPORTVAR: META_CATEGORY. Okay. Again, my apologies about that; I've excised it, and removed all of the EXPORTVAR directives, even the ones that had been commented out. (Note that the patch includes a change to xinstall, that is commented = out; that's because I think I still like the concept of it, to at least some degree, = and didn't want to forget where I put it. But it *is* commented out, and so the = functionality is simply not there.) Without my idiotic error, the diff is much smaller -- just under 50,000 = bytes. However, rather than include it again, I've replaced the file at = http://earth.kithrup.com/~sef/auto-diffs.txt for everyone's perusal. Thank you again, Sean.