From owner-freebsd-current@FreeBSD.ORG Tue Mar 24 15:43:03 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 520AA1065676 for ; Tue, 24 Mar 2009 15:43:03 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-gx0-f176.google.com (mail-gx0-f176.google.com [209.85.217.176]) by mx1.freebsd.org (Postfix) with ESMTP id 09F8B8FC14 for ; Tue, 24 Mar 2009 15:43:02 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: by gxk24 with SMTP id 24so8924473gxk.19 for ; Tue, 24 Mar 2009 08:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/PjxJqqFYSu8EIADAeMX/E9WxCL3o3HF8Fb60hpNGhE=; b=S0rIMfQM1EAMBqQ1OnvxSH37TSpbbvEXLQQcViifgyXCv4KjlOevYRs7BxkdHqwLj8 +ysbLzC5rnP+O1WLCrsS3FZcGDsYYE7CJq4kyFIJMmWwer4tKHFutbgiY2HfdS6S0X/1 /8AXxwUYS8liEUsSzy4+gIa/Ekg81+y4SGj/E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=j/pxE3+L/B812ZrQBXR2BjzVGxYhi52DmB8Y//G4PbZ/CO5FO9YxuH1cgZau1x5Gg3 hbcf0LB8B32Uv+Giwv3iWGcpYauXr8i7XufkjAjLbGs207YuKovwY3MuyeYXsQwErmwQ AcLWj35f24e3ABLjAeZ6TlC8cPIxLy9Yue3/c= MIME-Version: 1.0 Received: by 10.100.216.10 with SMTP id o10mr7618393ang.137.1237909372968; Tue, 24 Mar 2009 08:42:52 -0700 (PDT) In-Reply-To: References: <49C80DBA.80407@entel.upc.edu> Date: Tue, 24 Mar 2009 10:42:52 -0500 Message-ID: <790a9fff0903240842k6ab28ab5k1d1a46714fdfe804@mail.gmail.com> From: Scot Hetzel To: Ben Kelly Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Gustau Perez , freebsd-current@freebsd.org Subject: Re: Inline definition problem in current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2009 15:43:04 -0000 On Mon, Mar 23, 2009 at 10:05 PM, Ben Kelly wrote: > On Mar 23, 2009, at 6:31 PM, Gustau Perez wrote: >> >> a few time ago I switched to current, right now I've it updated to >> yesterday. =A0While compiling some ports (in fact, building x11/gnome2) = I >> found that some of them (written in C) are using =A0some inline function= s (I >> guess it is because the compiler will replace the call to the function w= ith >> the function itself). The problem is that gcc fails with the following >> message : >> =A0 =A0 =A0 =A0 =A0 =A0 error: nested function 'XXX' declared but never = defined >> >> =A0checking the code, the function is declared and then implemented in a >> header file which is included in the offending .c file. The function is >> declared as 'inline'. The only solution I found is to change the definit= ion >> to static. >> >> =A0Checking pontyhat shows me that many ports are failing because of thi= s >> problem. What I can understand is why is this happening, because the sam= e >> ports compiles fine in STABLE and the compilers's version in base seems = to >> be the same (gcc (GCC) 4.2.1 20070719 =A0[FreeBSD], the same in current) >> =A0Can anyone help with this problem ? > > Check out the arch@ discussion about "C99 Inlines" and this commit: > > =A0http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D189824 > > It seems like they might be related. > > Hope that helps. > I can confirm that reverting this change allows the audio/faad port to buil= d. Scot