From owner-p4-projects@FreeBSD.ORG  Wed May 30 14:18:57 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 12F8016A469; Wed, 30 May 2007 14:18:57 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DD9DB16A421
	for <perforce@FreeBSD.org>; Wed, 30 May 2007 14:18:56 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id 9672913C455
	for <perforce@FreeBSD.org>; Wed, 30 May 2007 14:18:54 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id BB27B8BD6E4
	for <perforce@FreeBSD.org>; Wed, 30 May 2007 16:18:52 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id STLC1MXsrenv for <perforce@FreeBSD.org>;
	Wed, 30 May 2007 16:18:51 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 79E828BD6DF
	for <perforce@FreeBSD.org>; Wed, 30 May 2007 16:18:51 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l4UEIppt045798
	for perforce@FreeBSD.org; Wed, 30 May 2007 16:18:51 +0200 (CEST)
	(envelope-from rdivacky)
Date: Wed, 30 May 2007 16:18:51 +0200
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Message-ID: <20070530141851.GA45778@freebsd.org>
References: <200705291445.l4TEjOqo072275@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200705291445.l4TEjOqo072275@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.2i
Cc: 
Subject: Re: PERFORCE change 120558 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2007 14:18:57 -0000

On Tue, May 29, 2007 at 02:45:24PM +0000, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=120558
> 
> Change 120558 by rdivacky@rdivacky_witten on 2007/05/29 14:44:59
> 
> 	Dont allow zero or negative pid/tid arguments to tgkill/tkill.
> 
> Affected files ...
> 
> .. //depot/projects/soc2007/rdivacky/linux_futex/sys/compat/linux/linux_signal.c#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2007/rdivacky/linux_futex/sys/compat/linux/linux_signal.c#2 (text+ko) ====
> 
> @@ -550,8 +550,8 @@
>  	ka.pid = args->pid;
>  	ka.signum = args->sig;
>  
> -	if (args->tgid == -1)
> -	   	return linux_kill(td, &ka);
> +	if (args->pid <= 0 || args->tgid <= 0)
> +		return EINVAL;

this is a WIP and might be wrapped in if (linux_use26(td)), hard to say ;(