From owner-cvs-ports@FreeBSD.ORG  Sun Nov 28 15:26:24 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id D63041065674; Sun, 28 Nov 2010 15:26:24 +0000 (UTC)
Date: Sun, 28 Nov 2010 15:26:24 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
Message-ID: <20101128152624.GB717@FreeBSD.org>
References: <201011270201.oAR21awa042310@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201011270201.oAR21awa042310@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/databases Makefile
	ports/databases/py-flask-sqlalchemy Makefile distinfo
	pkg-descr pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Nov 2010 15:26:24 -0000

On Sat, Nov 27, 2010 at 02:01:36AM +0000, Philip M. Gollucci wrote:
> pgollucci    2010-11-27 02:01:35 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     databases            Makefile 
>   Added files:
>     databases/py-flask-sqlalchemy Makefile distinfo pkg-descr 
>                                   pkg-plist 
>   Log:
>   Flask-SQLAlchemy adds support for SQLAlchemy to your Flask application.
>   
>   WWW:    http://pypi.python.org/pypi/Flask-SQLAlchemy
>   
>   PR:             ports/151626
>   Submitted by:   Olivier Duchateau <duchateau.olivier at gmail.com>

- Makefile is severely unindented
- PORTNAME is just disgustingly non-FreeBSDish [*]
- COMMENT should not be based on a verb instead of noun
- Missing tab in second RUN_DEPENDS line
- LICENSE should be better placed after COMMENT
- Port description contains style bug (tab after WWW:) and is identical to
  comment, ergo useless

[*] Original submission (which I've reviwed) did not contain this bug.
Why did you introduce it?

Please fix.

./danfe