From owner-cvs-all@FreeBSD.ORG  Tue Apr 29 10:37:16 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2C29B37B41C; Tue, 29 Apr 2003 10:37:14 -0700 (PDT)
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B0BE343FBF; Tue, 29 Apr 2003 10:37:13 -0700 (PDT)
	(envelope-from gallatin@cs.duke.edu)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu
	[152.3.145.30])
	by duke.cs.duke.edu (8.12.9/8.12.9) with ESMTP id h3THbDMS025492
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Tue, 29 Apr 2003 13:37:13 -0400 (EDT)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.11.6/8.9.1) id h3THb8384258;
	Tue, 29 Apr 2003 13:37:08 -0400 (EDT)
	(envelope-from gallatin@cs.duke.edu)
Date: Tue, 29 Apr 2003 13:37:08 -0400
From: Andrew Gallatin <gallatin@cs.duke.edu>
To: Warner Losh <imp@FreeBSD.org>
Message-ID: <20030429133708.A84234@grasshopper.cs.duke.edu>
References: <200304290545.h3T5j99Y076513@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200304290545.h3T5j99Y076513@repoman.freebsd.org>;
	from imp@FreeBSD.org on Mon, Apr 28, 2003 at 10:45:09PM -0700
X-Operating-System: FreeBSD 4.4-RELEASE on an i386
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Apr 2003 17:37:16 -0000

Warner Losh [imp@FreeBSD.org] wrote:
>           2) Call FXP_UNLOCK() before calling bus_teardown_intr to avoid
>              a possible deadlock reported by jhb.
>           3) add gone to the softc.  Set it to true in detach.

>           5) Return immediately if gone is true in fxp_intr
>   

My workstation has been up for ~5 hours now, and has seen 1.3 million 
fxp interrupts.  That's 1.3 million extra compares that this code
is now executing.

What is this deadlock with bus_teardown_intr?  Could we possibly fix
this some other way than by adding (mostly) useless code to the
critical path? 

Drew