From owner-svn-src-all@freebsd.org Tue Sep 20 04:54:15 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FC5FBE0332; Tue, 20 Sep 2016 04:54:15 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C579B1C5D; Tue, 20 Sep 2016 04:54:14 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x244.google.com with SMTP id l132so1266221wmf.1; Mon, 19 Sep 2016 21:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=iU5c6IyHFUZijWDdcLmvUC5XHXgFeC2ozu8/cMHiKiM=; b=bryHtz0RjtRu5baQb91yMz5cf002lH7pZCk/4c5DBT30JNR3IexMud2AwsQTeWg6GW lM0dn2pd+OWBhwFozvFOhNJEBhpK/qjP/7D7G3XJ3glA48ACqrFuYqxk12hCeWkjwzpN AwAWD6B9UPtabVCRShKRt5/UPj02poVjGpm7SHwAIHbcTz2GkW30yF14fgI6Wj/sB7/4 j+edG4MV3i1YWwiRddpgzKKbSNnHoxDJ2MsE7MCDgOzSWWQzksIWj/TKZRABS9p615tu nR/8jTtKgkxlMY7K2qmlmvUxHjugQBDLHr1TKmZF0JRN/UbuYxQAd7XovVf/2oUI31VF l6VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=iU5c6IyHFUZijWDdcLmvUC5XHXgFeC2ozu8/cMHiKiM=; b=TipftsqsNAWeFYfeg5jsUaX3Tuc/A7Obt8gTVm4BCcz/iK8LWolnUcesKUntzrHmJ6 InCBtVhEB1snG2Zm1BCwB4fIDXWinRGUcXZmSRfXgmJI7I9v6/v+Bq0+sm/RjaJpc3uh i4zof5jWB0LY2uSB6BbqDKsRHhRCy96wbmEM8Xzs6dbMix/0iKwpI/AA/UmfZx8qhJui yTEESFXYh3EaUT4JSCFFJxTK8j50eC7ZD6lEfFaO5JFL0QlKdyqb6LObQrC6gl4nllNA 51J65kYFrefGXBHCOktSsZP1CIPO3pHSd/Jbf+RJ1GNuyZoWzg/uSLgwa2HJPfcjsLvO g44g== X-Gm-Message-State: AE9vXwNjVpnACC7wNrsYC20lPRrasj8/8G5UC9zod1QUqZ5w4I2QFmfOafs6NFjJ4e+06Q== X-Received: by 10.28.4.72 with SMTP id 69mr1244178wme.91.1474347253370; Mon, 19 Sep 2016 21:54:13 -0700 (PDT) Received: from brick (etn137.neoplus.adsl.tpnet.pl. [83.20.159.137]) by smtp.gmail.com with ESMTPSA id md9sm26272740wjb.20.2016.09.19.21.54.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Sep 2016 21:54:12 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Tue, 20 Sep 2016 06:54:10 +0200 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Warner Losh Cc: Ronald Klop , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r305968 - head/etc/autofs Message-ID: <20160920045410.GA10272@brick> Mail-Followup-To: Warner Losh , Ronald Klop , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201609190851.u8J8pRDD068198@repo.freebsd.org> <20160920034337.GA6180@brick> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 04:54:15 -0000 Good point; fixed. On 0919T2219, Warner Losh wrote: > For MSDOS it's one thing and likely helps. But for ufs it doesn't > help. Soft updates already does an excellent job at reducing wear and > all async does is give added danger of dataloss. Linux distros don't > matter for UFS because different design decisions have been made for > ext[234] and UFS. > > Warner > > On Mon, Sep 19, 2016 at 9:43 PM, Edward Tomasz Napierala > wrote: > > Mounting removable media async improves performance and reduces wear. > > And AFAIK that's what most Linux distros used to do. > > > > On 0919T2032, Ronald Klop wrote: > >> Hi, > >> > >> Your commit message says in words exactly what the diff says in code. > >> Would you like to elaborate on why the change is made? I'm curious > >> because this could cause severe damage to the filesystem on unclean eject > >> of the media. > >> > >> Regards, > >> Ronald. > >> > >> > >> On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala > >> wrote: > >> > >> > Author: trasz > >> > Date: Mon Sep 19 08:51:27 2016 > >> > New Revision: 305968 > >> > URL: https://svnweb.freebsd.org/changeset/base/305968 > >> > > >> > Log: > >> > Make autofs use the "async" flag for msdosfs and ufs filesystems > >> > mounted > >> > on /media. > >> > MFC after: 1 month > >> > > >> > Modified: > >> > head/etc/autofs/special_media > >> > > >> > Modified: head/etc/autofs/special_media > >> > ============================================================================== > >> > --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 (r305967) > >> > +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 (r305968) > >> > @@ -46,6 +46,8 @@ print_map_entry() { > >> > "Cannot mount ${_fstype} formatted device /dev/${_p}: Install > >> > sysutils/fusefs-ntfs first" > >> > exit 1 > >> > fi > >> > + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then > >> > + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" > >> > else > >> > echo "-fstype=${_fstype},nosuid :/dev/${_p}" > >> > fi > >> > _______________________________________________ > >> > svn-src-all@freebsd.org mailing list > >> > https://lists.freebsd.org/mailman/listinfo/svn-src-all > >> > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > >