From owner-svn-src-head@freebsd.org Thu Jun 20 15:29:22 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9C5B15BF0FE; Thu, 20 Jun 2019 15:29:21 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76D74860D1; Thu, 20 Jun 2019 15:29:21 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f194.google.com with SMTP id 16so3085137ljv.10; Thu, 20 Jun 2019 08:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y3EIUnoLo62+axnRclDonxUQ0B/VAx0rVNKzSxlwJs4=; b=ugmZRbaKIND3oppzz1aEpN4c6gpOhXNIMwdYhSSl7fBu+Jbmh+yG+UYcbRWcP8HWeS 1Tb9TG31kDcC4U6tkzS4GH0/c/Xpgb0RB2RuH8OoaSJSkoIL7xc8VLNyr9TnC2nqsDhW tsdGqpw2yTrWDQncjIoQr1LLip1Y/oyk4yGIUjjw1A9d6Lk/wRAa+kUeoyViksskWAz7 7eSLQ7cX5d/wwE/iF/CvS4NPV7jSGPPCH1h08R7nw/ubuGt9kmNPorinb7Wbd+HudGTD cKUcjg0/rfr+vISgCxnRnW5XthyUq9hPjZq0q/g9ap7XXZtc8KIWDjZlv8nPxAsYFVgE VFkA== X-Gm-Message-State: APjAAAXLT7PS2pGpwA8EwR2aY2XIb5jiglWsZVP4utCkpOcFHsKYXbS+ 9coDxfJLiBnaEBLOSXpwpjQD2nwjQ7czhbJfANV9pu2v X-Google-Smtp-Source: APXvYqzS3BidN4g1Ky9f74q2yh/Ig0NggF50d8QaKQSFGpTDDhMymxRLWCKxQDjlyrUnkEDdGuT15ZEzzaGHdmJE6g0= X-Received: by 2002:a2e:9dc1:: with SMTP id x1mr5209636ljj.0.1561044553704; Thu, 20 Jun 2019 08:29:13 -0700 (PDT) MIME-Version: 1.0 References: <201906201435.x5KEZTqH021513@repo.freebsd.org> <54f3bc97cbb485cdcc44b81c82c149ac9e46d42f.camel@freebsd.org> In-Reply-To: <54f3bc97cbb485cdcc44b81c82c149ac9e46d42f.camel@freebsd.org> From: Alan Somers Date: Thu, 20 Jun 2019 09:29:01 -0600 Message-ID: Subject: Re: svn commit: r349233 - head/sys/sys To: Ian Lepore Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 76D74860D1 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.973,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 15:29:22 -0000 On Thu, Jun 20, 2019 at 9:14 AM Ian Lepore wrote: > > On Thu, 2019-06-20 at 14:35 +0000, Alan Somers wrote: > > Author: asomers > > Date: Thu Jun 20 14:35:28 2019 > > New Revision: 349233 > > URL: https://svnweb.freebsd.org/changeset/base/349233 > > > > Log: > > #include from sys/filio.h > > > > This fixes world build after r349231 > > > > Reported by: Jenkins > > MFC after: 2 weeks > > MFC-With: 349231 > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/sys/sys/filio.h > > > > Modified: head/sys/sys/filio.h > > ===================================================================== > > ========= > > --- head/sys/sys/filio.h Thu Jun 20 14:34:45 2019 (r349232) > > +++ head/sys/sys/filio.h Thu Jun 20 14:35:28 2019 (r349233) > > @@ -40,6 +40,7 @@ > > #ifndef _SYS_FILIO_H_ > > #define _SYS_FILIO_H_ > > > > +#include > > #include > > > > /* Generic file-descriptor ioctl's. */ > > > > I wonder... is this one of those situations where it is better to use > __int64_t in the struct, then #include ? I think the net > effect there would be less pollution with other types? I've never seen > written guidance about when to use the __names and _types.h, but I've > always had the general impression that if you have to include a header > from another system header, it's better to use the _header.h if it > exists. > > -- Ian Good question. grep shows almost equal numbers of each (37 types.h and 33 _types.h) in sys/sys. Do you think I should change it? -Alan