From owner-cvs-all Sun Feb 24 11: 4: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by hub.freebsd.org (Postfix) with ESMTP id 4472437B400; Sun, 24 Feb 2002 11:04:00 -0800 (PST) Received: from scsiguy.com (localhost [127.0.0.1]) by aslan.scsiguy.com (8.11.6/8.11.5) with ESMTP id g1OJ4YI78683; Sun, 24 Feb 2002 12:04:34 -0700 (MST) (envelope-from gibbs@scsiguy.com) Message-Id: <200202241904.g1OJ4YI78683@aslan.scsiguy.com> To: Matt Dillon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c In-Reply-To: Your message of "Thu, 21 Feb 2002 11:15:10 PST." <200202211915.g1LJFAi09419@freefall.freebsd.org> Date: Sun, 24 Feb 2002 12:04:34 -0700 From: "Justin T. Gibbs" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >dillon 2002/02/21 11:15:10 PST > > Modified files: (Branch: RELENG_4) > sys/kern kern_shutdown.c > Log: > If a system shutdown is performed immediately after doing softupdates-heavy > filesystem operations the shutdown code may stall on buffers being held > locked by softupdates, resulting an unclean shutdown. These buffers are > never unlocked because the syncer has already been killed. The solution is > to call bioops.io_sync() in the shutdown code. Hmm. Can't this be handled in some more generic fashion? I can't believe that the syncer is the only "special process" that may want to clean things up during shutdown. I suppose we don't kill it off by trying to SIGTERM (or some equivalent) it first? A generic mechanism would allow the special behavior to be localized to the area needing it instead (and where that behavior might change) rather than in the middle of the generic shutdown code. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message