Date: Thu, 1 Oct 2015 15:06:06 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r288454 - head/usr.bin/truss Message-ID: <CAHSQbTAfkTusEETcZX-jsKcmYU4K4sf_eHUKa7-E%2B6STjg598w@mail.gmail.com> In-Reply-To: <5360523.S6ag5ugNqo@ralph.baldwin.cx> References: <201510011728.t91HS7fo006633@repo.freebsd.org> <5360523.S6ag5ugNqo@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
powerpc64 also defines __powerpc64__ in addition to __powerpc__. This is likely because unlike amd64, the only major difference between 32-bit and 64-bit is the register size, so mips will likely be the same way. -Justin On Oct 1, 2015 2:51 PM, "John Baldwin" <jhb@freebsd.org> wrote: > On Thursday, October 01, 2015 05:28:07 PM John Baldwin wrote: > > Author: jhb > > Date: Thu Oct 1 17:28:07 2015 > > New Revision: 288454 > > URL: https://svnweb.freebsd.org/changeset/base/288454 > > > > Log: > > - Remove extra integer argument from truncate() and ftruncate(). This > is > > probably fallout from the removal of the extra padding argument > before > > off_t in 7. However, that padding still exists for 32-bit powerpc, > so > > use QUAD_ALIGN. > > - Fix QUAD_ALIGN to be zero for powerpc64. It should only be set to 1 > > for 32-bit platforms that add padding to align 64-bit arguments. > > I'm not sure how the situation is on arm and MIPS, but on powerpc, both the > 32-bit and 64-bit platforms define __powerpc__ (unlike amd64 which doesn't > define __i386__ for example) making proper #ifdef's for just 32-bit > __powerpc__ a bit of a PITA. > > -- > John Baldwin > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHSQbTAfkTusEETcZX-jsKcmYU4K4sf_eHUKa7-E%2B6STjg598w>