From owner-svn-src-head@freebsd.org Thu Oct 1 20:06:07 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4315AA0DF4B; Thu, 1 Oct 2015 20:06:07 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F1181121; Thu, 1 Oct 2015 20:06:07 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by igxx6 with SMTP id x6so2888304igx.1; Thu, 01 Oct 2015 13:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7UZMvBd0zj3yPoIwvsLfN5i4MGWkYH+ufJOJTfCqW0I=; b=tP+GfeBgk51P3t4vWq0yq/yj0fxkznTa1jy2Dyr2JDxubr2kdgGzEC0pZKAlah5Iip I3nfAFEtCoT7y0rtPfd0kLYsBekOFbhGkA+njKowMXqvvsQ9AwKuX5selsEglX9e3AKM eq2AQ7PBuaWB6uWu7X6xCWfuFfcns4OWK67c0yfg0mXIY7K+RqCOeCW8MjWuH7JnjLwy SZTYXN8KP/9/joIWVZQLymCVin8pDI6aGy0KaF8plTcMBb5yCH70zcdKcDE/Hvjrb/rJ WaRIhbdehlz/QfqSFg1div09BQ6BVsiX2VRVoNRupw0wiQxJ1Zg2EWoiUfKQQJX6J5NA MNyw== MIME-Version: 1.0 X-Received: by 10.50.78.40 with SMTP id y8mr852559igw.8.1443729966478; Thu, 01 Oct 2015 13:06:06 -0700 (PDT) Received: by 10.36.41.138 with HTTP; Thu, 1 Oct 2015 13:06:06 -0700 (PDT) Received: by 10.36.41.138 with HTTP; Thu, 1 Oct 2015 13:06:06 -0700 (PDT) In-Reply-To: <5360523.S6ag5ugNqo@ralph.baldwin.cx> References: <201510011728.t91HS7fo006633@repo.freebsd.org> <5360523.S6ag5ugNqo@ralph.baldwin.cx> Date: Thu, 1 Oct 2015 15:06:06 -0500 Message-ID: Subject: Re: svn commit: r288454 - head/usr.bin/truss From: Justin Hibbits To: John Baldwin Cc: src-committers , svn-src-head@freebsd.org, svn-src-all@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2015 20:06:07 -0000 powerpc64 also defines __powerpc64__ in addition to __powerpc__. This is likely because unlike amd64, the only major difference between 32-bit and 64-bit is the register size, so mips will likely be the same way. -Justin On Oct 1, 2015 2:51 PM, "John Baldwin" wrote: > On Thursday, October 01, 2015 05:28:07 PM John Baldwin wrote: > > Author: jhb > > Date: Thu Oct 1 17:28:07 2015 > > New Revision: 288454 > > URL: https://svnweb.freebsd.org/changeset/base/288454 > > > > Log: > > - Remove extra integer argument from truncate() and ftruncate(). This > is > > probably fallout from the removal of the extra padding argument > before > > off_t in 7. However, that padding still exists for 32-bit powerpc, > so > > use QUAD_ALIGN. > > - Fix QUAD_ALIGN to be zero for powerpc64. It should only be set to 1 > > for 32-bit platforms that add padding to align 64-bit arguments. > > I'm not sure how the situation is on arm and MIPS, but on powerpc, both the > 32-bit and 64-bit platforms define __powerpc__ (unlike amd64 which doesn't > define __i386__ for example) making proper #ifdef's for just 32-bit > __powerpc__ a bit of a PITA. > > -- > John Baldwin > >