From owner-freebsd-current@FreeBSD.ORG  Fri Aug  5 08:26:46 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BEAFE106566B;
	Fri,  5 Aug 2011 08:26:46 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A02E8FC14;
	Fri,  5 Aug 2011 08:26:45 +0000 (UTC)
Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua
	[10.1.1.148])
	by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p758QeTc061083
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 5 Aug 2011 11:26:40 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1])
	by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id
	p758Qe44076268; Fri, 5 Aug 2011 11:26:40 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
Received: (from kostik@localhost)
	by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p758Qe9f076267; 
	Fri, 5 Aug 2011 11:26:40 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to
	kostikbel@gmail.com using -f
Date: Fri, 5 Aug 2011 11:26:40 +0300
From: Kostik Belousov <kostikbel@gmail.com>
To: Martin Matuska <mm@freebsd.org>
Message-ID: <20110805082640.GQ17489@deviant.kiev.zoral.com.ua>
References: <20110804125454.GI29364@albert.catwhisker.org>
	<20110804135932.GG17489@deviant.kiev.zoral.com.ua>
	<4E3BA769.3090408@FreeBSD.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="fpc9xpxSwr8iiS8p"
Content-Disposition: inline
In-Reply-To: <4E3BA769.3090408@FreeBSD.org>
User-Agent: Mutt/1.4.2.3i
X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua
X-Virus-Status: Clean
X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DNS_FROM_OPENWHOIS autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	skuns.kiev.zoral.com.ua
Cc: Xin Li <delphij@freebsd.org>, current@freebsd.org
Subject: Re: panic: share -> excl @r224632
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Aug 2011 08:26:46 -0000


--fpc9xpxSwr8iiS8p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 05, 2011 at 10:18:49AM +0200, Martin Matuska wrote:
> I agree to Kostik's  approach, but I suggest implementing it in a
> separate function and also use for the unmount() part.
>=20
> Please review attached patch.
Since you are moving the fragment to a function, you may somewhat reduce
the code duplication by moving at least free() and return to the end
of function and jumping to it.

Also, after more looking at this, I think now that the check for VI_DOOMED
is not needed, due to relookup and comparision of vp and vp1.

--fpc9xpxSwr8iiS8p
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAk47qT8ACgkQC3+MBN1Mb4jmtgCgtCob+OYGFugy+XXWnc4Ot1LN
DHQAoL/xOsJYQUZWntIacNHOwFdFFdbw
=Ol9R
-----END PGP SIGNATURE-----

--fpc9xpxSwr8iiS8p--