From owner-svn-src-all@FreeBSD.ORG  Tue Dec 17 01:29:37 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8AE6EEDC;
 Tue, 17 Dec 2013 01:29:37 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0408115B6;
 Tue, 17 Dec 2013 01:29:36 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rBH1TXYf051215
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 17 Dec 2013 05:29:34 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rBH1TXG9051214;
 Tue, 17 Dec 2013 05:29:33 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 17 Dec 2013 05:29:33 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: svn commit: r259475 - head/sys/kern
Message-ID: <20131217012933.GY29088@FreeBSD.org>
References: <201312161931.rBGJVOhs083409@svn.freebsd.org>
 <20131216204021.GW29088@FreeBSD.org>
 <CAJ-VmokxmRqm=mVEHzDeQkKeWCRJatchpJGm93uDM8HyQ1wtew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ-VmokxmRqm=mVEHzDeQkKeWCRJatchpJGm93uDM8HyQ1wtew@mail.gmail.com>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Dec 2013 01:29:37 -0000

On Mon, Dec 16, 2013 at 04:54:15PM -0800, Adrian Chadd wrote:
A> Ok. I'll go find where I copy pastes thus from. The mbuf code perhaps?
A> 
A> Should we do a big quick tidy up?

Nope, the mbuf code is somewhat different, due to secondary zones. An
item freed there isn't actually freed, that's why they need a shift of
trashing memory not in ctor/dtor, but in init/fini. Actually, now I see
that your code is not only extraneous but wrong.  You probably wanted to
set ctor/dtor methods, not init/fini. So just remove it, in case of INVARIANTS
the UMA automatically does all needed trash filling and later checking.


-- 
Totus tuus, Glebius.