From owner-cvs-all@FreeBSD.ORG  Mon Jul  4 07:51:08 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id CA3E11065672;
	Mon,  4 Jul 2011 07:51:08 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 48F8114EC70;
	Mon,  4 Jul 2011 07:51:08 +0000 (UTC)
Message-ID: <4E1170EB.2030003@FreeBSD.org>
Date: Mon, 04 Jul 2011 00:51:07 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.18) Gecko/20110624 Thunderbird/3.1.11
MIME-Version: 1.0
To: Alex Samorukov <samm@os2.kiev.ua>
References: <201107021323.p62DNWeP082020@repoman.freebsd.org>
	<4E0FB8DF.90904@FreeBSD.org> <4E105B9B.4060602@os2.kiev.ua>
In-Reply-To: <4E105B9B.4060602@os2.kiev.ua>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Martin Wilke <miwi@FreeBSD.org>
Subject: Re: cvs commit: ports/sysutils/atop Makefile distinfo
 ports/sysutils/atop/files atop.in pkg-message.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2011 07:51:08 -0000

On 07/03/2011 05:07, Alex Samorukov wrote:
> Hello,
>
> Thank you for comments.
>
> On 07/03/2011 02:33 AM, Doug Barton wrote:
>> Overall this looks good, just 2 small comments. It's not clear why it
>> uses:
>>
>> # REQUIRE: DAEMON
>> # BEFORE: LOGIN
>>
>> Instead of just
>>
>> # REQUIRE: LOGIN
>>
>> like most ports scripts do.
> Probably my copypaste from some other script. Better to replace with
> REQUIRE: LOGIN.
>
>  > Also the default empty assignment for _flags is neither necessary or
> desirable.
>
> Agree. Do i need to submit PR to fix this or you can do it without it?

All set, thanks. :)


-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/