From owner-svn-src-head@FreeBSD.ORG Tue Feb 10 21:54:23 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68ECF10656D7; Tue, 10 Feb 2009 21:54:23 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 555E48FC08; Tue, 10 Feb 2009 21:54:23 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1ALsNGP005357; Tue, 10 Feb 2009 21:54:23 GMT (envelope-from marius@svn.freebsd.org) Received: (from marius@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1ALsNCh005356; Tue, 10 Feb 2009 21:54:23 GMT (envelope-from marius@svn.freebsd.org) Message-Id: <200902102154.n1ALsNCh005356@svn.freebsd.org> From: Marius Strobl Date: Tue, 10 Feb 2009 21:54:23 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188457 - head/sys/dev/bge X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2009 21:54:24 -0000 Author: marius Date: Tue Feb 10 21:54:23 2009 New Revision: 188457 URL: http://svn.freebsd.org/changeset/base/188457 Log: Don't reset the PHY probe retry counter within the loop so it will eventually terminate as intended. Submitted by: Helen Zhang Modified: head/sys/dev/bge/if_bge.c Modified: head/sys/dev/bge/if_bge.c ============================================================================== --- head/sys/dev/bge/if_bge.c Tue Feb 10 21:51:33 2009 (r188456) +++ head/sys/dev/bge/if_bge.c Tue Feb 10 21:54:23 2009 (r188457) @@ -2674,11 +2674,11 @@ bge_attach(device_t dev) * if we get a conflict with the ASF firmware accessing * the PHY. */ + trys = 0; BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP); again: bge_asf_driver_up(sc); - trys = 0; if (mii_phy_probe(dev, &sc->bge_miibus, bge_ifmedia_upd, bge_ifmedia_sts)) { if (trys++ < 4) {