Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Dec 2010 22:16:15 +0000 (UTC)
From:      Ulrich Spoerlein <uqs@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r216544 - head/bin/sh
Message-ID:  <201012182216.oBIMGF2E033656@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: uqs
Date: Sat Dec 18 22:16:15 2010
New Revision: 216544
URL: http://svn.freebsd.org/changeset/base/216544

Log:
  Remove dead code.
  
  c is assigned 0 and *loc is pointing to NULL, so c!=0 cannot be true,
  and dereferencing loc would be a bad idea anyway.
  
  Coverity Prevent:	CID 5113
  Reviewed by:		jilles

Modified:
  head/bin/sh/expand.c

Modified: head/bin/sh/expand.c
==============================================================================
--- head/bin/sh/expand.c	Sat Dec 18 20:56:49 2010	(r216543)
+++ head/bin/sh/expand.c	Sat Dec 18 22:16:15 2010	(r216544)
@@ -557,8 +557,6 @@ subevalvar(char *p, char *str, int strlo
 		amount = startp - expdest;
 		STADJUST(amount, expdest);
 		varflags &= ~VSNUL;
-		if (c != 0)
-			*loc = c;
 		return 1;
 
 	case VSQUESTION:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012182216.oBIMGF2E033656>