From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug 25 23:00:37 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A3A7416A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 25 Aug 2004 23:00:37 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 747ED43D1D
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 25 Aug 2004 23:00:37 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i7PN0bKW037936
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 25 Aug 2004 23:00:37 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i7PN0bAw037935;
	Wed, 25 Aug 2004 23:00:37 GMT
	(envelope-from gnats)
Resent-Date: Wed, 25 Aug 2004 23:00:37 GMT
Resent-Message-Id: <200408252300.i7PN0bAw037935@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	SANETO Takanori <sanewo@ba2.so-net.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A925516A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 25 Aug 2004 22:53:30 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9E9A643D1F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 25 Aug 2004 22:53:30 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i7PMrUbI087895
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Aug 2004 22:53:30 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i7PMrUaq087894;
	Wed, 25 Aug 2004 22:53:30 GMT
	(envelope-from nobody)
Message-Id: <200408252253.i7PMrUaq087894@www.freebsd.org>
Date: Wed, 25 Aug 2004 22:53:30 GMT
From: SANETO Takanori <sanewo@ba2.so-net.ne.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: bin/70960: "ndc restart" dumps core when named is running with
	options
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2004 23:00:37 -0000


>Number:         70960
>Category:       bin
>Synopsis:       "ndc restart" dumps core when named is running with options
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 25 23:00:36 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     SANETO Takanori
>Release:        5.2-CURRENT
>Organization:
an individual
>Environment:
FreeBSD muse.sanewo.ddo.jp 5.2-CURRENT FreeBSD 5.2-CURRENT #321: Mon Aug 16 23:41:11 JST 2004     root@muse.sanewo.ddo.jp:/export/usr/obj/usr/src/sys/MUSE  i386
>Description:
      When named is running with options (e.g. "/usr/sbin/named -u bind"), "ndc restart" cause core dump.

>How-To-Repeat:
      as described above.
>Fix:
      Following patch to ndc.c should fix this. I confirmed that ISC bind-8.4.4 has this fix in it.

retrieving revision 1.1.1.7
diff -u -r1.1.1.7 ndc.c
--- contrib/bind/bin/ndc/ndc.c  17 Jun 2003 08:24:06 -0000      1.1.1.7
+++ contrib/bind/bin/ndc/ndc.c  25 Aug 2004 15:21:23 -0000
@@ -353,6 +353,7 @@
                *tp++ = c;
                cp++;
        }
+       *tp = '\0';
 }

 static int

>Release-Note:
>Audit-Trail:
>Unformatted: