From owner-cvs-ports@FreeBSD.ORG Thu Mar 17 09:56:59 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87F121065670; Thu, 17 Mar 2011 09:56:59 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from unimail.uni-dortmund.de (mx1.HRZ.Uni-Dortmund.DE [129.217.128.51]) by mx1.freebsd.org (Postfix) with ESMTP id 1CB3F8FC1A; Thu, 17 Mar 2011 09:56:58 +0000 (UTC) Received: from apollo.emma.line.org (g227133027.adsl.alicedsl.de [92.227.133.27]) (authenticated bits=0) by unimail.uni-dortmund.de (8.14.4/8.14.4) with ESMTP id p2H9HWfZ015648 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Thu, 17 Mar 2011 10:17:33 +0100 (CET) Message-ID: <4D81D1AC.1020705@FreeBSD.org> Date: Thu, 17 Mar 2011 10:17:32 +0100 From: Matthias Andree User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; de-DE; rv:1.9.2.15) Gecko/20110306 Mnenhy/0.8.3 Thunderbird/3.1.9 MIME-Version: 1.0 To: Alexey Dokuchaev References: <201103170003.p2H03lCu061081@repoman.freebsd.org> <20110317070735.GA50416@FreeBSD.org> In-Reply-To: <20110317070735.GA50416@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/gpart Makefile distinfo ports/sysutils/gpart/files patch-ae patch-af X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2011 09:56:59 -0000 Am 17.03.2011 08:07, schrieb Alexey Dokuchaev: > On Thu, Mar 17, 2011 at 12:03:47AM +0000, Matthias Andree wrote: >> mandree 2011-03-17 00:03:47 UTC >> >> Modified files: >> sysutils/gpart Makefile distinfo >> Added files: >> sysutils/gpart/files patch-ae patch-af >> Log: >> First round of amd64 fixes. Compiles and detects BSD partitions, but >> may require work for NTFS, NTFS5, or other partitions. [...] >> >> Revision Changes Path >> 1.16 +7 -6 ports/sysutils/gpart/Makefile >> 1.9 +0 -1 ports/sysutils/gpart/distinfo >> 1.1 +34 -0 ports/sysutils/gpart/files/patch-ae (new) >> 1.1 +96 -0 ports/sysutils/gpart/files/patch-af (new) > > Perhaps you could explain why did you decide to go with legacy patch > naming scheme when it is clearly advised to be avoided by PH? Alexey, I do appreciate your eyeballs on my commits, the German saying is that four eyes see more than two, and I do subscribe to QA and code reviews in general. But perhaps you can save us all a bit of work by skimming through later commit messages, too, where you would have seen that I'd rectified that before you'd posted your question :-) The answer was "patch ordering". I needed to sort out two-patches-for-one-file (also not in line with the porter's conventions). That broke with "make makepatch". combinediff came to the rescue. (Is there a CVS-based tool for the add-added-and-remove-removed-files task that, for instance, SVN's loaddirs or Git's subcommands can do?) Best regards -- Matthias Andree ports committer