From owner-svn-src-stable-12@freebsd.org Thu Oct 29 16:18:16 2020 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECB3A457212; Thu, 29 Oct 2020 16:18:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CMVwl68Jmz40sf; Thu, 29 Oct 2020 16:18:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 09TGHpoI003874 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 29 Oct 2020 18:17:54 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 09TGHpoI003874 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 09TGHpqu003873; Thu, 29 Oct 2020 18:17:51 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 29 Oct 2020 18:17:51 +0200 From: Konstantin Belousov To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r367049 - stable/12/libexec/rc/rc.d Message-ID: <20201029161751.GA2654@kib.kiev.ua> References: <202010260118.09Q1IGo7016376@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202010260118.09Q1IGo7016376@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4CMVwl68Jmz40sf X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-0.08 / 15.00]; ARC_NA(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-0.11)[-0.106]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_SPAM_MEDIUM(0.40)[0.402]; NEURAL_HAM_SHORT(-0.38)[-0.376]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-stable,svn-src-stable-12]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 16:18:17 -0000 On Mon, Oct 26, 2020 at 01:18:16AM +0000, Cy Schubert wrote: > Author: cy > Date: Mon Oct 26 01:18:15 2020 > New Revision: 367049 > URL: https://svnweb.freebsd.org/changeset/base/367049 > > Log: > MFC r366857: > Destroy cloned interfaces at netif stop, netif restart and shutdown. > This is especially important during shutdown because a child interface > of lagg with WOL enabled will not enable WOL at interface shutdown and > thus no WOL to wake up the device (and machine). > > PR: 158734, 109980 > Reported by: Antonio Huete Jimenez > Marat N.Afanasyev > reviewed by: kp > > Modified: > stable/12/libexec/rc/rc.d/netif > Directory Properties: > stable/12/ (props changed) > > Modified: stable/12/libexec/rc/rc.d/netif > ============================================================================== > --- stable/12/libexec/rc/rc.d/netif Mon Oct 26 00:37:31 2020 (r367048) > +++ stable/12/libexec/rc/rc.d/netif Mon Oct 26 01:18:15 2020 (r367049) > @@ -28,7 +28,7 @@ > # PROVIDE: netif > # REQUIRE: FILESYSTEMS iovctl serial sppp sysctl > # REQUIRE: hostid ipfs > -# KEYWORD: nojailvnet > +# KEYWORD: nojailvnet shutdown > > . /etc/rc.subr > . /etc/network.subr After this change, shutdown of my stable/12 router looks like this: Stopping devd. Waiting for PIDS: 1120. Oct 29 18:09:52 tom minissdpd[1619]: setsockopt(udp, IP_DROP_MEMBERSHIP)(vlan1): Can't assign requested address /etc/rc.shutdown: WARNING: vlan1 does not exist. Skipped. /etc/rc.shutdown: WARNING: vlan2 does not exist. Skipped. /etc/rc.shutdown: WARNING: vlan3 does not exist. Skipped. /etc/rc.shutdown: WARNING: vlan4 does not exist. Skipped. /etc/rc.shutdown: WARNING: vlan5 does not exist. Skipped. Stopping Network: lo0 re0 re1 pflog0 gif0. lo0: flags=8048 metric 0 mtu 16384 options=680003 groups: lo nd6 options=21 re0: flags=8802 metric 0 mtu 1500 options=201b ether e0:d5:5e:50:93:04 media: Ethernet autoselect (1000baseT ) status: active nd6 options=29 re1: flags=8802 metric 0 mtu 1500 options=201b ether e0:d5:5e:50:93:05 media: Ethernet autoselect (100baseTX ) status: active nd6 options=29 pflog0: flags=100 metric 0 mtu 33160 groups: pflog gif0: flags=8010 metric 0 mtu 1280 options=80000 tunnel inet 176.36.249.139 --> 216.66.84.46 groups: gif nd6 options=21 Destroyed clone interfaces: gif0. Writing entropy file: . . Terminated Oct 29 18:09:53 tom syslogd: exiting on signal 15 pflog0: promiscuous mode disabled Waiting (max 60 seconds) for system process `vnlru' to stop... done Waiting (max 60 seconds) for system process `syncer' to stop... Syncing disks, vnodes remaining... 14 2 2 1 1 1 0 0 0 0 done