Date: Wed, 25 Apr 2012 16:55:31 +0200 From: rank1seeker@gmail.com To: "John Baldwin" <jhb@freebsd.org>, dougb@freebsd.org, hackers@freebsd.org Subject: Re: Forgotten debuging flags in 9.0 RELEASE Message-ID: <20120425.145531.264.3@DOMY-PC> In-Reply-To: <201204251014.56568.jhb@freebsd.org> References: <20120421.164328.068.1@DOMY-PC> <201204231428.49712.jhb@freebsd.org> <20120425.133709.484.2@DOMY-PC> <201204251014.56568.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message -----
From: John Baldwin <jhb@freebsd.org>
To: rank1seeker@gmail.com
Cc: dougb@freebsd.org, hackers@freebsd.org
Date: Wed, 25 Apr 2012 10:14:56 -0400
Subject: Re: Forgotten debuging flags in 9.0 RELEASE
> On Wednesday, April 25, 2012 9:37:09 am rank1seeker@gmail.com wrote:
> > ----- Original Message -----
> > From: John Baldwin <jhb@freebsd.org>
> > To: freebsd-hackers@freebsd.org
> > Cc: rank1seeker@gmail.com, dougb@freebsd.org
> > Date: Mon, 23 Apr 2012 14:28:49 -0400
> > Subject: Re: Forgotten debuging flags in 9.0 RELEASE
> >
> > > On Saturday, April 21, 2012 12:43:28 pm rank1seeker@gmail.com wrote:
> > > > Whenever I run:
> > > > # make distribution
> > > >
> > > > I also get:
> > > > + ln -s ../var/named/etc/namedb /usr/TZONE/etc/namedb
> > > > + ln -s mail/aliases /usr/TZONE/etc/aliases
> > > >
> > > > Looks like someone forgot to turn off/remove debuging flags(set -x),
> before
> > > building 9.0 RELEASE
> > >
> > > Actually, those have been there for at least 7 years. The namedb one was
> > > first added in r136242, and the mail one is older than that.
> > >
> > > > /usr/src/etc/Makefile:
> > > > ----
> > > > @if [ ! -e ${DESTDIR}/etc/namedb ]; then \
> > > > set -x; \
> > > > ln -s ../var/named/etc/namedb ${DESTDIR}/etc/namedb; \
> > > > fi
> > > > ----
> > > > @if [ -d ${DESTDIR}/etc/mail -a -f ${DESTDIR}/etc/mail/aliases -
> a \
> > > > ! -f ${DESTDIR}/etc/aliases ]; then \
> > > > set -x; \
> > > > ln -s mail/aliases ${DESTDIR}/etc/aliases; \
> > > > fi
> > > > ----
> > >
> > > --
> > > John Baldwin
> > >
> >
> >
> > 7 years ?!?
> > Wow, it's time to get rid of them, unless someone finds it criticaly
> useful/needed.
>
> Alternatively, it hasn't broken anything in 7 years. :)
LOL. Vey funny!
> > My build script had many set -x lines, so I was thinking it was my script
> outputing it.
> > I thought I was going mad, by being unable to find where am I using 'ln -s'
> lines, even after I've removed all 'set -x' lines
>
> I will defer to dougb@ on this one as it is a chunk of the code he maintains.
> You will have to convince him that the verbosity is somehow harmful.
>
> --
> John Baldwin
Well, those can be left in place, if they are part of STDOUT, as I leave only STDERR to reach my eyes.
And I see exactly those 2 'ln -s ...' lines because they are outputed to STDERR.
Domagoj Smolčić
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120425.145531.264.3>