Date: Wed, 13 Feb 2019 14:28:02 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r344095 - stable/11/sys/dev/ixgbe Message-ID: <201902131428.x1DES2XK035718@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: marius Date: Wed Feb 13 14:28:02 2019 New Revision: 344095 URL: https://svnweb.freebsd.org/changeset/base/344095 Log: MFC: r343203 ixgbe: this statement may fall through warnings with gcc The recent gcc versions (7 and 8 at least) can check for switch case statements for fall through (implicit-fallthrough). When fall through is intentional, the default method for warning suppression is to place comment /* FALLTHROUGH */ exactly before next case statement. Differential Revision: https://reviews.freebsd.org/D18577 Modified: stable/11/sys/dev/ixgbe/ixgbe_82599.c stable/11/sys/dev/ixgbe/ixgbe_common.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/dev/ixgbe/ixgbe_82599.c ============================================================================== --- stable/11/sys/dev/ixgbe/ixgbe_82599.c Wed Feb 13 14:27:59 2019 (r344094) +++ stable/11/sys/dev/ixgbe/ixgbe_82599.c Wed Feb 13 14:28:02 2019 (r344095) @@ -1746,7 +1746,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *h case 0x0000: /* mask VLAN ID */ fdirm |= IXGBE_FDIRM_VLANID; - /* fall through */ + /* FALLTHROUGH */ case 0x0FFF: /* mask VLAN priority */ fdirm |= IXGBE_FDIRM_VLANP; @@ -2032,7 +2032,7 @@ s32 ixgbe_fdir_add_perfect_filter_82599(struct ixgbe_h DEBUGOUT(" Error on src/dst port\n"); return IXGBE_ERR_CONFIG; } - /* fall through */ + /* FALLTHROUGH */ case IXGBE_ATR_FLOW_TYPE_TCPV4: case IXGBE_ATR_FLOW_TYPE_TUNNELED_TCPV4: case IXGBE_ATR_FLOW_TYPE_UDPV4: Modified: stable/11/sys/dev/ixgbe/ixgbe_common.c ============================================================================== --- stable/11/sys/dev/ixgbe/ixgbe_common.c Wed Feb 13 14:27:59 2019 (r344094) +++ stable/11/sys/dev/ixgbe/ixgbe_common.c Wed Feb 13 14:28:02 2019 (r344095) @@ -267,7 +267,8 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw) if (ret_val != IXGBE_SUCCESS) goto out; - /* fall through - only backplane uses autoc */ + /* only backplane uses autoc */ + /* FALLTHROUGH */ case ixgbe_media_type_fiber_fixed: case ixgbe_media_type_fiber_qsfp: case ixgbe_media_type_fiber: @@ -4732,7 +4733,8 @@ void ixgbe_set_rxpba_generic(struct ixgbe_hw *hw, int rxpktsize <<= IXGBE_RXPBSIZE_SHIFT; for (; i < (num_pb / 2); i++) IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize); - /* fall through - configure remaining packet buffers */ + /* configure remaining packet buffers */ + /* FALLTHROUGH */ case PBA_STRATEGY_EQUAL: rxpktsize = (pbsize / (num_pb - i)) << IXGBE_RXPBSIZE_SHIFT; for (; i < num_pb; i++)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902131428.x1DES2XK035718>